Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java

Summary

Maintainability
F
3 days
Test Coverage

File AbstractGroup.java has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* AbstractGroup.java


    Purpose:
    Description:
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 4 hrs to fix

    Method checkAdd has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

            private void checkAdd(Item newVal, Item other, boolean replace) {
            //allowed type?
            if (!(newVal instanceof Element) && !(newVal instanceof Text)
            && !(newVal instanceof CData) && !(newVal instanceof Comment)
            && !(newVal instanceof EntityReference) && !(newVal instanceof Binary)
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method coalesce has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public final int coalesce(boolean recursive) {
        int count = 0;
        Item found = null;
        StringBuilder sb = new StringBuilder();
        for (final Iterator<Item> it = _children.iterator(); it.hasNext();) {
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    AbstractGroup has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public abstract class AbstractGroup extends AbstractItem implements Group {
    /** The list of the children. Never null.
     */
    protected List<Item> _children;
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 2 hrs to fix

      Method getElements has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public final List<Element> getElements(String namespace, String name, int mode) {
        if (_elemMap != null && namespace == null && mode == FIND_BY_TAGNAME)
            return getElements(name); //use the speed version

        final Pattern ptn =
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getElement has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public final Element getElement(String namespace, String name, int mode) {
        if (_elemMap != null && namespace == null && mode == FIND_BY_TAGNAME)
            return getElement(name); //use the speed version

        int j = getElementIndex(0, namespace, name, mode);
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method checkAdd has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private void checkAdd(Item newVal, Item other, boolean replace) {
            //allowed type?
            if (!(newVal instanceof Element) && !(newVal instanceof Text)
            && !(newVal instanceof CData) && !(newVal instanceof Comment)
            && !(newVal instanceof EntityReference) && !(newVal instanceof Binary)
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 1 hr to fix

        Method coalesce has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public final int coalesce(boolean recursive) {
        int count = 0;
        Item found = null;
        StringBuilder sb = new StringBuilder();
        for (final Iterator<Item> it = _children.iterator(); it.hasNext();) {
        Severity: Minor
        Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                      if (!(newVal instanceof Element) && !(newVal instanceof Text)
            && !(newVal instanceof CData) && !(newVal instanceof Comment)
            && !(newVal instanceof EntityReference) && !(newVal instanceof Binary)
            && !(newVal instanceof ProcessingInstruction))
                throw new DOMException(HIERARCHY_REQUEST_ERR, "Invalid type", getLocator());
          Severity: Major
          Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (node instanceof Element) {
                                eOther = (Element) node;
                                break;
                            }
            Severity: Major
            Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 45 mins to fix

              Method put has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      public final void put(Element e, Element following) {
            final String name = e.getName();
            List<Element> valueList = _map.computeIfAbsent(name,
                    k -> new LinkedList<>());
              Severity: Minor
              Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getElementIndex has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public final int getElementIndex
    (int indexFrom, String namespace, String name, int mode) {
        if (indexFrom < 0 || indexFrom >= _children.size())
            return -1;
              Severity: Minor
              Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (!(newVal instanceof Element) && !(newVal instanceof Text)
            && !(newVal instanceof CData) && !(newVal instanceof Comment)
            && !(newVal instanceof EntityReference) && !(newVal instanceof Binary)
              Severity: Minor
              Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractGroup.java and 1 other location - About 40 mins to fix
              zcommon/src/main/java/org/zkoss/idom/Document.java on lines 261..264

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status