Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/idom/impl/AbstractItem.java

Summary

Maintainability
C
1 day
Test Coverage

AbstractItem has 49 methods (exceeds 20 allowed). Consider refactoring.
Open

public abstract class AbstractItem
implements Item, Node, Serializable, Cloneable {
    private static final long serialVersionUID = 20060622L;

    /** The parent. */
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractItem.java - About 6 hrs to fix

    Method match has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        protected static boolean match
    (Namespaceable vtx, String namespace, String name, Pattern ptn, int mode) {
        if (name != null) {
            String val = (mode & FIND_BY_TAGNAME) != 0 ?
                vtx.getTagName(): vtx.getLocalName();
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractItem.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method match has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        (Namespaceable vtx, String namespace, String name, Pattern ptn, int mode) {
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractItem.java - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in zcommon/src/main/java/org/zkoss/idom/impl/AbstractItem.java - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status