Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/io/Files.java

Summary

Maintainability
D
1 day
Test Coverage

Method normalize has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public static final String normalize(String path) {
        if (path == null)
            return "";

        //remove consecutive slashes
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Files.java has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* Files.java


    Purpose: File related utilities.
    Description:
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 2 hrs to fix

    Method copy has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public static final void copy(File dst, File src, int flags)
    throws IOException {
        if (!src.exists())
            throw new FileNotFoundException(src.toString());
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method normalize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static final String normalize(String path) {
        if (path == null)
            return "";

        //remove consecutive slashes
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 1 hr to fix

      Method normalize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public static final String normalize(String parentPath, String childPath) {
        if (childPath == null || childPath.length() == 0)
            return normalize(parentPath);
        if ((parentPath == null || parentPath.length() == 0)
        || childPath.charAt(0) == '/')
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method copyFile has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private static final void copyFile(File dst, File src, int flags)
    throws IOException {
        if (dst.equals(src))
            throw new IOException("Copy to the same file, "+src);
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method locate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public static final String locate(String flnm) {
        int j = flnm.indexOf('*');
        if (j < 0) return flnm;

        final String postfix = flnm.substring(j + 1);
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method deleteAll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static final boolean deleteAll(File file) {
        if (file.isDirectory()) {
            final File[] fls = file.listFiles();
            for (int j = 0; j < fls.length; ++j) {
                if (!deleteAll(fls[j]))
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method removeDotDot has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private static int removeDotDot(StringBuffer sb, int j) {
        int k = j;
        while (--k >= 0 && sb.charAt(k) != '/') 
            ;
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/io/Files.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static final void copy(Writer writer, Reader reader)
    throws IOException {
        final char[] buf = new char[1024*4];
        for (int v; (v = reader.read(buf)) >= 0;) {
            if (v > 0)
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/io/Files.java and 1 other location - About 55 mins to fix
      zcommon/src/main/java/org/zkoss/io/Files.java on lines 107..114

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static final void copy(OutputStream out, InputStream in)
    throws IOException {
        final byte[] buf = new byte[1024*8];
        for (int v; (v = in.read(buf)) >= 0;) {
            if (v > 0)
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/io/Files.java and 1 other location - About 55 mins to fix
      zcommon/src/main/java/org/zkoss/io/Files.java on lines 94..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status