Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/io/RepeatableReader.java

Summary

Maintainability
D
1 day
Test Coverage

Method close has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public void close() throws IOException {
        _cntsz = 0;
        if (_org != null) {
            _org.close();
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public int read(char cbuf[], int off, int len) throws IOException {
        if (_org != null) {
            final int cnt = _org.read(cbuf, off, len);
            if (!_nobuf)
                if (cnt >= 0) {
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getWriter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private Writer getWriter() throws IOException {
        if (_out == null)
            return _nobuf ? null: (_out = new StringWriter());
                //it is possible _membufsz <= 0, but OK to use memory first
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method disableBuffering has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private void disableBuffering() {
        _nobuf = true;
        if (_out != null) {
            try {
                _out.close();
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void close() throws IOException {
        _cntsz = 0;
        if (_org != null) {
            _org.close();
Severity: Major
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java and 1 other location - About 2 hrs to fix
zcommon/src/main/java/org/zkoss/io/RepeatableInputStream.java on lines 259..288

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 153.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private static class RepeatableURLReader extends Reader implements Repeatable,
            Serializable {
        private final URL _url;
        private Reader _in;
        private final String _charset;
Severity: Major
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java and 1 other location - About 1 hr to fix
zcommon/src/main/java/org/zkoss/io/RepeatableReader.java on lines 366..397

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private static class RepeatableFileReader extends Reader implements Repeatable,
            Serializable {
        private final File _file;
        private Reader _in;
        private final String _charset;
Severity: Major
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java and 1 other location - About 1 hr to fix
zcommon/src/main/java/org/zkoss/io/RepeatableReader.java on lines 398..429

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private void disableBuffering() {
        _nobuf = true;
        if (_out != null) {
            try {
                _out.close();
Severity: Major
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java and 1 other location - About 1 hr to fix
zcommon/src/main/java/org/zkoss/io/RepeatableInputStream.java on lines 201..217

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (_org != null) {
            final int cnt = _org.read(cbuf, off, len);
            if (!_nobuf)
                if (cnt >= 0) {
                    final Writer out = getWriter();
Severity: Major
Found in zcommon/src/main/java/org/zkoss/io/RepeatableReader.java and 1 other location - About 1 hr to fix
zcommon/src/main/java/org/zkoss/io/RepeatableInputStream.java on lines 239..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status