Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/lang/Exceptions.java

Summary

Maintainability
D
1 day
Test Coverage

Method unwrap has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public static final Throwable unwrap(Throwable ex) {
        for (;;) {
            if (ex instanceof InvocationTargetException)
                ex = ex.getCause(); //might returns UndeclaredThrowableException
            else if (ex instanceof UndeclaredThrowableException)
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method formatStackTrace has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public static final StringBuffer
    formatStackTrace(StringBuffer sb, Throwable t, String prefix, int maxcnt) {
        final StringWriter sw = new StringWriter();
        t.printStackTrace(new PrintWriter(sw));
        final StringBuffer trace = sw.getBuffer();
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getCause has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public static final Throwable getCause(Throwable ex) {
        Throwable t = ex.getCause();
        if (t == null)
            try {
                if (ex instanceof java.rmi.RemoteException) {
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method formatStackTrace has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static final StringBuffer
    formatStackTrace(StringBuffer sb, Throwable t, String prefix, int maxcnt) {
        final StringWriter sw = new StringWriter();
        t.printStackTrace(new PrintWriter(sw));
        final StringBuffer trace = sw.getBuffer();
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 1 hr to fix

    Method getMessage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static final String getMessage(Throwable ex) {
        String s;
        for (Throwable t = ex;;) {
            s = t.getMessage();
            if (s != null && s.length() > 0)
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if (maxcnt > 0 || prefix.length() > 0) {
            final int len = trace.length();
            if (sb == null)
                 sb = new StringBuffer(len + 256);
            if (maxcnt <= 0)
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 40 mins to fix

      Method myToAnother has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private static final Throwable
    myToAnother(Throwable ex, Class<? extends Throwable> targetExceptCls) {
        if (ex instanceof InvocationTargetException)
            ex = ex.getCause(); //might returns UndeclaredThrowableException
        if (ex instanceof UndeclaredThrowableException)
      Severity: Minor
      Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return t;
      Severity: Major
      Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return ((java.rmi.RemoteException)ex).detail;
        Severity: Major
        Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static final Throwable
    wrap(Throwable ex, Class<? extends Throwable> targetExceptCls, int code, Object[] fmtArgs) {
        ex = myToAnother(ex, targetExceptCls);
        if (targetExceptCls.isInstance(ex))
            return ex;
          Severity: Major
          Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java and 1 other location - About 1 hr to fix
          zcommon/src/main/java/org/zkoss/lang/Exceptions.java on lines 244..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public static final Throwable
    wrap(Throwable ex, Class<? extends Throwable> targetExceptCls, int code, Object fmtArg) {
        ex = myToAnother(ex, targetExceptCls);
        if (targetExceptCls.isInstance(ex))
            return ex;
          Severity: Major
          Found in zcommon/src/main/java/org/zkoss/lang/Exceptions.java and 1 other location - About 1 hr to fix
          zcommon/src/main/java/org/zkoss/lang/Exceptions.java on lines 221..236

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status