Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/math/RoundingModes.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method valueOf has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public static final int valueOf(String name) {
        name = name.toUpperCase();
        if ("CEILING".equals(name)) return BigDecimal.ROUND_CEILING;
        if ("DOWN".equals(name)) return BigDecimal.ROUND_DOWN;
        if ("FLOOR".equals(name)) return BigDecimal.ROUND_FLOOR;
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/math/RoundingModes.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        if ("HALF_UP".equals(name)) return BigDecimal.ROUND_HALF_UP;
Severity: Major
Found in zcommon/src/main/java/org/zkoss/math/RoundingModes.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            if ("UNNECESSARY".equals(name)) return BigDecimal.ROUND_UNNECESSARY;
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/math/RoundingModes.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              if ("UP".equals(name)) return BigDecimal.ROUND_UP;
      Severity: Major
      Found in zcommon/src/main/java/org/zkoss/math/RoundingModes.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                if ("HALF_EVEN".equals(name)) return BigDecimal.ROUND_HALF_EVEN;
        Severity: Major
        Found in zcommon/src/main/java/org/zkoss/math/RoundingModes.java - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status