Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/sound/AAudio.java

Summary

Maintainability
D
1 day
Test Coverage

Method getFormat0 has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    private String getFormat0() throws IOException {
        String format = null;
        if (_data != null) {
            try {
                format =
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getFormat0 has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private String getFormat0() throws IOException {
        String format = null;
        if (_data != null) {
            try {
                format =
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java - About 1 hr to fix

    Method getName has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private static String getName(URL url) {
        String name = url.getPath();
        if (name != null) {
            {
                final int j = name.lastIndexOf(File.pathSeparatorChar);
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private static String getName(URL url) {
        String name = url.getPath();
        if (name != null) {
            {
                final int j = name.lastIndexOf(File.pathSeparatorChar);
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java and 1 other location - About 1 hr to fix
    zcommon/src/main/java/org/zkoss/image/AImage.java on lines 140..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        private static String getFormatByName(String name) {
        if (name != null) {
            final int j = name.lastIndexOf('.') + 1,
                k = name.lastIndexOf('/') + 1;
            if (j > k && j < name.length())
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java and 2 other locations - About 1 hr to fix
    zcommon/src/main/java/org/zkoss/image/AImage.java on lines 158..166
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 232..240

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public AAudio(File file) {
        if (file == null)
            throw new IllegalArgumentException("null url");
        _name = file.getName();
        _file = file;
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java and 3 other locations - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/sound/AAudio.java on lines 107..115
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 110..118
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 123..131

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public AAudio(URL url) {
        if (url == null)
            throw new IllegalArgumentException("null url");
        _name = getName(url);
        _url = url;
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java and 3 other locations - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/sound/AAudio.java on lines 118..126
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 110..118
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 123..131

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public AAudio(String name, InputStream isdata) throws IOException {
        if (isdata == null)
            throw new IllegalArgumentException("null stream");
        _name = name;
        _isdata = isdata;
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java and 3 other locations - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/sound/AAudio.java on lines 78..86
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 78..86
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 97..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public AAudio(String name, byte[] data) throws IOException {
        if (data == null)
            throw new IllegalArgumentException("null data");
        _name = name;
        _data = data;
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java and 3 other locations - About 50 mins to fix
    zcommon/src/main/java/org/zkoss/sound/AAudio.java on lines 96..104
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 78..86
    zcommon/src/main/java/org/zkoss/video/AVideo.java on lines 97..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            } else if (_file != null) {
            try {
                format = AudioSystem.getAudioFileFormat(_file)
                    .getType().getExtension();
            } catch (UnsupportedAudioFileException ex) {
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java and 1 other location - About 45 mins to fix
    zcommon/src/main/java/org/zkoss/sound/AAudio.java on lines 256..265

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            } else if (_url != null) {
            try {
                format = AudioSystem.getAudioFileFormat(_url)
                    .getType().getExtension();
            } catch (UnsupportedAudioFileException ex) {
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/sound/AAudio.java and 1 other location - About 45 mins to fix
    zcommon/src/main/java/org/zkoss/sound/AAudio.java on lines 247..256

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status