Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/text/MessageFormats.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method parseByName has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public static final NameInfo parseByName(String pattern) {
        final Map<String,Integer> names = new LinkedHashMap<String,Integer>();
        final int len = pattern.length();
        final StringBuffer sb = new StringBuffer(len + 32);
        int j = 0;
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/text/MessageFormats.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseByName has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static final NameInfo parseByName(String pattern) {
        final Map<String,Integer> names = new LinkedHashMap<String,Integer>();
        final int len = pattern.length();
        final StringBuffer sb = new StringBuffer(len + 32);
        int j = 0;
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/text/MessageFormats.java - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status