Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/util/resource/Locators.java

Summary

Maintainability
C
1 day
Test Coverage

Method myLocate has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    private static final Object
    myLocate(String file, Locale locale, Locator locator, boolean asStream) {
        if (locale == null)
            locale = Locales.getCurrent();
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/util/resource/Locators.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method myLocate has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static final Object
    myLocate(String file, Locale locale, Locator locator, boolean asStream) {
        if (locale == null)
            locale = Locales.getCurrent();
Severity: Major
Found in zcommon/src/main/java/org/zkoss/util/resource/Locators.java - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            if (k > 0) sb.append('_');
    Severity: Major
    Found in zcommon/src/main/java/org/zkoss/util/resource/Locators.java - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status