Sign upLogin

zkoss/zk

View on GitHub
Star
zcommon/src/main/java/org/zkoss/xel/taglib/Taglibs.java

Summary

Maintainability
C
1 day
Test Coverage

Method getFunctionMapper has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public static final FunctionMapper getFunctionMapper(Collection<Taglib> taglibs,
    Map<String, Class<?>> imports, Collection<FunctionDefinition> funcs, Locator loc) {
        TaglibMapper mapper = null;
        if (taglibs != null && !taglibs.isEmpty()) {
            mapper = new TaglibMapper();
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/xel/taglib/Taglibs.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static final TaglibDefinition load(Element root) throws Exception {
        final TaglibDefinition tagdef = new TaglibDefinition();
        Exception excp = null;
        for (Element e: root.getElements("function")) {
            final String name = IDOMs.getRequiredElementValue(e, "name");
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/xel/taglib/Taglibs.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static final TaglibDefinition load(Element root) throws Exception {
        final TaglibDefinition tagdef = new TaglibDefinition();
        Exception excp = null;
        for (Element e: root.getElements("function")) {
            final String name = IDOMs.getRequiredElementValue(e, "name");
Severity: Minor
Found in zcommon/src/main/java/org/zkoss/xel/taglib/Taglibs.java - About 1 hr to fix

    Method getDefaultTLDs has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private static final Map<String, URL> getDefaultTLDs() {
        Map<String, URL> defURLs = _defURLsRef.get();
        if (defURLs != null) {
            return defURLs;
        }
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/xel/taglib/Taglibs.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getDefaultTLDs has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static final Map<String, URL> getDefaultTLDs() {
        Map<String, URL> defURLs = _defURLsRef.get();
        if (defURLs != null) {
            return defURLs;
        }
    Severity: Minor
    Found in zcommon/src/main/java/org/zkoss/xel/taglib/Taglibs.java - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status