Sign upLogin

zkoss/zk

View on GitHub
Star
zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java

Summary

Maintainability
F
3 days
Test Coverage

Method setVisible has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean setVisible(boolean visible) {
        final boolean old = super.setVisible(visible);
        if (old != visible) {
            final String style = getStyle();
            if (visible) {
Severity: Minor
Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

AbstractTag has 52 methods (exceeds 20 allowed). Consider refactoring.
Open

public class AbstractTag extends AbstractComponent implements DynamicPropertied, RawId {
    static {
        addClientEvent(AbstractTag.class, Events.ON_CLICK, 0);
    }
Severity: Major
Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 7 hrs to fix

    File AbstractTag.java has 371 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* AbstractTag.java

    Purpose:
        
    Description:
    Severity: Minor
    Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 4 hrs to fix

      Method setVisible has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public boolean setVisible(boolean visible) {
        final boolean old = super.setVisible(visible);
        if (old != visible) {
            final String style = getStyle();
            if (visible) {
      Severity: Minor
      Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 1 hr to fix

        Method getPrologHalf has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            /* package */ String getPrologHalf(boolean hideUuidIfNoId) {
        final StringBuilder sb = new StringBuilder(128).append('<').append(_tagnm);

//        Do this at client side for ZK-5270
//        if ((!hideUuidIfNoId && !shallHideId()) || getId().length() > 0)
        Severity: Minor
        Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method filterStyle has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private String filterStyle(String style) {
        if (style != null) {
            final int j = HTMLs.getSubstyleIndex(style, "display");
            if (j >= 0) { // display is specified
                super.setVisible(!"none".equals(HTMLs.getSubstyleValue(style, j)));
        Severity: Minor
        Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                if ("none".equals(val)) {
                            String newstyle = style.substring(0, j);
                            final int k = style.indexOf(';', j + 7);
                            if (k >= 0)
                                newstyle += style.substring(k + 1);
        Severity: Major
        Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 45 mins to fix

          Method setDynamicProperty has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public void setDynamicProperty(String name, Object value) throws WrongValueException {
        if (name == null)
            throw new WrongValueException("name is required");
        if (!hasDynamicProperty(name))
            throw new WrongValueException("Attribute not allowed: " + name
          Severity: Minor
          Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method redraw has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public void redraw(java.io.Writer out) throws java.io.IOException {
        if (_tagnm == null)
            throw new UiException("The tag name is not initialized yet");

        final Execution exec = Executions.getCurrent();
          Severity: Minor
          Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setDynaProp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private void setDynaProp(String name, Object value) {
        if (value == null) {
            if (_props != null)
                _props.remove(name);
        } else {
          Severity: Minor
          Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              static {
        _properties.put("id", new StringPropertyAccess() {
            public void setValue(Component cmp, String value) {
                ((AbstractTag) cmp).setId(value);
            }
          Severity: Major
          Found in zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java and 2 other locations - About 2 hrs to fix
          zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java on lines 417..456
          zul/src/main/java/org/zkoss/zul/Combobox.java on lines 1222..1259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 168.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status