Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java

Summary

Maintainability
F
4 days
Test Coverage

Method redraw has a Cognitive Complexity of 104 (exceeds 5 allowed). Consider refactoring.
Open

    public void redraw(Writer out) throws java.io.IOException {
        //Note: _tag == null can NOT be handled specially
        final Execution exec = Executions.getCurrent();
        final boolean root = getParent() == null && (getPage().isComplete()
                || (exec != null && "complete".equals(ExecutionsCtrl.getPageRedrawControl(exec))));
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method redraw has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void redraw(Writer out) throws java.io.IOException {
        //Note: _tag == null can NOT be handled specially
        final Execution exec = Executions.getCurrent();
        final boolean root = getParent() == null && (getPage().isComplete()
                || (exec != null && "complete".equals(ExecutionsCtrl.getPageRedrawControl(exec))));
Severity: Major
Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java - About 4 hrs to fix

    HtmlNativeComponent has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class HtmlNativeComponent extends AbstractComponent implements DynamicTag, Native { //cannot be RawId since two native might have the same ID
    private static final Helper _helper = new HtmlHelper();
    private static final String ATTR_RENDER_CONTEXT = "org.zkoss.zk.native.renderContext";

    //---------
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java - About 3 hrs to fix

      File HtmlNativeComponent.java has 324 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* HtmlNativeComponent.java

    Purpose:
        
    Description:
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java - About 3 hrs to fix

        Method setDynamicProperty has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public void setDynamicProperty(String name, Object value) throws WrongValueException {
        if (name == null)
            throw new WrongValueException("name required");

        if (value == null) {
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                if (html >= 0)
                            junav = sb.lastIndexOf("</html");
        Severity: Major
        Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if ("div".equals(tn) || "span".equals(tn)) {
                            l_loop: for (int j = 0, len = sb.length(); j < len; ++j)
                                switch (sb.charAt(j)) {
                                case '>':
                                    disableUnavailable = true; //make output cleaner
          Severity: Major
          Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java - About 45 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                static {
        _properties.put("id", new StringPropertyAccess() {
            public void setValue(Component cmp, String value) {
                ((HtmlNativeComponent) cmp).setId(value);
            }
            Severity: Major
            Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java and 2 other locations - About 2 hrs to fix
            zhtml/src/main/java/org/zkoss/zhtml/impl/AbstractTag.java on lines 585..622
            zul/src/main/java/org/zkoss/zul/Combobox.java on lines 1222..1259

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 168.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public void addDeclaredNamespace(Namespace ns) {
        if (ns == null)
            throw new IllegalArgumentException();

        if (_dns == null)
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/HtmlNativeComponent.java and 1 other location - About 30 mins to fix
            zk/src/main/java/org/zkoss/zk/ui/metainfo/PageDefinition.java on lines 450..456

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status