Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java

Summary

Maintainability
F
3 days
Test Coverage

Method process has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    protected boolean process(Session sess, RenderRequest request, RenderResponse response, String path,
            boolean bRichlet) throws PortletException, IOException {
        //        if (log.isDebugEnabled()) log.debug("Creates from "+path);
        final WebManager webman = getWebManager();
        final WebApp wapp = webman.getWebApp();
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File DHtmlLayoutPortlet.java has 310 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* DHtmlLayoutPortlet.java

    Purpose:
        
    Description:
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 3 hrs to fix

    Method doView has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        protected void doView(RenderRequest request, RenderResponse response) throws PortletException, IOException {
        //try parameter first and then attribute
        boolean bRichlet = false;
        String path = request.getParameter(ATTR_PAGE);
        if (path == null) {
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handleError has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        private void handleError(Session sess, RenderRequest request, RenderResponse response, String path, Throwable err,
            String msg) throws PortletException, IOException {
        // ZK-3679
        Throwable cause;
        if (err instanceof OperationException && (cause = err.getCause()) instanceof Expectable)
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected boolean process(Session sess, RenderRequest request, RenderResponse response, String path,
            boolean bRichlet) throws PortletException, IOException {
        //        if (log.isDebugEnabled()) log.debug("Creates from "+path);
        final WebManager webman = getWebManager();
        final WebApp wapp = webman.getWebApp();
    Severity: Major
    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 2 hrs to fix

      Method doView has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected void doView(RenderRequest request, RenderResponse response) throws PortletException, IOException {
        //try parameter first and then attribute
        boolean bRichlet = false;
        String path = request.getParameter(ATTR_PAGE);
        if (path == null) {
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 1 hr to fix

        Method serveResource has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void serveResource(ResourceRequest request, ResourceResponse response) throws PortletException, IOException {
        final WebManager webman = getWebManager();
        final WebApp wapp = webman.getWebApp();

        final HttpServletRequest httpreq = ResourceHttpServletRequest.getInstance(request);
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 1 hr to fix

          Method handleError has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private void handleError(Session sess, RenderRequest request, RenderResponse response, String path, Throwable err,
            String msg) throws PortletException, IOException {
        // ZK-3679
        Throwable cause;
        if (err instanceof OperationException && (cause = err.getCause()) instanceof Expectable)
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 1 hr to fix

            Method handleError has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private void handleError(Session sess, RenderRequest request, RenderResponse response, String path, Throwable err,
            String msg) throws PortletException, IOException {
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if (!bRichlet) {
                            path = prefs.getValue(ATTR_RICHLET, null);
                            bRichlet = path != null;
                            if (!bRichlet)
                                path = _defpage;
              Severity: Major
              Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 45 mins to fix

                Method process has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    protected boolean process(Session sess, RenderRequest request, RenderResponse response, String path,
            boolean bRichlet) throws PortletException, IOException {
                Severity: Minor
                Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 35 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return true; //success
                  Severity: Major
                  Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 30 mins to fix

                    Method initializeRenderPatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                            private static PageRenderPatch initializeRenderPatch() {
            final String clsnm = Library.getProperty(org.zkoss.zk.ui.sys.Attributes.PORTLET_RENDER_PATCH_CLASS);
            if (clsnm == null) {
                return new PageRenderPatch() {
                    public Writer beforeRender(RequestInfo reqInfo) {
                    Severity: Minor
                    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    if (uf.isRichlet(ri, bRichlet)) {
                    final Richlet richlet = uf.getRichlet(ri, path);
                    if (richlet == null)
                        return false; //not found
                    Severity: Major
                    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java and 1 other location - About 2 hrs to fix
                    zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java on lines 292..307

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 152.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    } else if (path != null) {
                    final PageDefinition pagedef = uf.getPageDefinition(ri, path);
                    if (pagedef == null)
                        return false; //not found
                    Severity: Major
                    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java and 1 other location - About 2 hrs to fix
                    zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java on lines 277..292

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 152.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (errpg != null) {
                try {
                    request.setAttribute("javax.servlet.error.message", Exceptions.getMessage(err));
                    request.setAttribute("javax.servlet.error.exception", err);
                    request.setAttribute("javax.servlet.error.exception_type", err.getClass());
                    Severity: Major
                    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java and 1 other location - About 1 hr to fix
                    zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java on lines 305..319

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 112.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status