Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java

Summary

Maintainability
D
2 days
Test Coverage

Method process has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    protected boolean process(Session sess, HttpServletRequest request, HttpServletResponse response, String originPath,
            boolean bRichlet) throws ServletException, IOException {

        // Fix Server-Side Request Forgery (SSRF)
        String path = Https.sanitizePath(originPath);
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected boolean process(Session sess, HttpServletRequest request, HttpServletResponse response, String originPath,
            boolean bRichlet) throws ServletException, IOException {

        // Fix Server-Side Request Forgery (SSRF)
        String path = Https.sanitizePath(originPath);
Severity: Major
Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java - About 2 hrs to fix

    Method handleError has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        private void handleError(Session sess, HttpServletRequest request, HttpServletResponse response, String path,
            Throwable err) throws ServletException, IOException {
        Utils.resetOwner();

        // ZK-3679
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method init has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @SuppressWarnings("deprecation")
    public void init() throws ServletException {
        final ServletConfig config = getServletConfig();
        String param = config.getInitParameter("log-level");
        if (param != null && param.length() > 0) {
    Severity: Major
    Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java - About 2 hrs to fix

      Method init has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          @SuppressWarnings("deprecation")
    public void init() throws ServletException {
        final ServletConfig config = getServletConfig();
        String param = config.getInitParameter("log-level");
        if (param != null && param.length() > 0) {
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handleError has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private void handleError(Session sess, HttpServletRequest request, HttpServletResponse response, String path,
            Throwable err) throws ServletException, IOException {
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java - About 35 mins to fix

        Method process has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected boolean process(Session sess, HttpServletRequest request, HttpServletResponse response, String originPath,
            boolean bRichlet) throws ServletException, IOException {
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true; //success
          Severity: Major
          Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (compress && !voided) {
                final String result = ((StringWriter) out).toString();

                try {
                    final OutputStream os = response.getOutputStream();
            Severity: Major
            Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java and 1 other location - About 2 hrs to fix
            zk/src/main/java/org/zkoss/zk/ui/http/RichletFilter.java on lines 198..218

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 128.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (errpg != null) {
                try {
                    request.setAttribute("javax.servlet.error.message", Exceptions.getMessage(err));
                    request.setAttribute("javax.servlet.error.exception", err);
                    request.setAttribute("javax.servlet.error.exception_type", err.getClass());
            Severity: Major
            Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java and 1 other location - About 1 hr to fix
            zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutPortlet.java on lines 398..411

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (desktop != null) { //recycle
                final Page page = Utils.getMainPage(desktop);
                if (page != null) {
                    final Execution exec = new ExecutionImpl(ctx, request, response, desktop, page);
                    WebManager.setDesktop(request, desktop);
            Severity: Major
            Found in zk/src/main/java/org/zkoss/zk/ui/http/DHtmlLayoutServlet.java and 1 other location - About 1 hr to fix
            zk/src/main/java/org/zkoss/zk/ui/http/RichletFilter.java on lines 162..171

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status