Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java

Summary

Maintainability
D
2 days
Test Coverage

ExecutionImpl has 69 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ExecutionImpl extends AbstractExecution {
    private final ServletContext _ctx;
    private final HttpServletRequest _request;
    private final HttpServletResponse _response;
    private final RequestContext _xelctx;
Severity: Major
Found in zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java - About 1 day to fix

    File ExecutionImpl.java has 459 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* ExecutionImpl.java

    Purpose:
        
    Description:
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java - About 7 hrs to fix

      Method dispatch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private boolean dispatch(Writer out, String page, Map params, int mode, boolean include)
            throws IOException, ServletException {
        //FUTURE: handle if ~./, PASS_THRU_ATTR and with query string
        //In other words, we convert query string to params if
        //PASS_THRU_ATTR and ~./ (to have a better performance)
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method encodeURL has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public String encodeURL(String uri) {
        if (uri == null || uri.isEmpty()) // ZK-5598
            return uri;
        try {
            String encodedURL = Encodes.encodeURL(_ctx, _request, _response, uri);
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method dispatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private boolean dispatch(Writer out, String page, Map params, int mode, boolean include)
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java - About 35 mins to fix

        Method evaluate0 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private Object evaluate0(Object self, String expr, Class<?> expectedType, Page page) {
        if (expr == null || expr.length() == 0 || expr.indexOf("${") < 0) {
            if (expectedType == Object.class || expectedType == String.class)
                return expr;
            return Classes.coerce(expectedType, expr);
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                try {
            if (!dispatch(out, page, params, mode, true))
                Servlets.include(_ctx, _request, HttpBufferedResponse.getInstance(_response, out), page, params, mode);
        } catch (ServletException ex) {
            throw new UiException(ex);
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java and 1 other location - About 45 mins to fix
        zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java on lines 274..279

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                try {
            if (!dispatch(out, page, params, mode, false))
                Servlets.forward(_ctx, _request, HttpBufferedResponse.getInstance(_response, out), page, params, mode);
        } catch (ServletException ex) {
            throw new UiException(ex);
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java and 1 other location - About 45 mins to fix
        zk/src/main/java/org/zkoss/zk/ui/http/ExecutionImpl.java on lines 202..207

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status