Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java

Summary

Maintainability
D
1 day
Test Coverage

File WebManager.java has 415 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* WebManager.java

    Purpose:
        
    Description:
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java - About 5 hrs to fix

    WebManager has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class WebManager {
    private static final Logger log = LoggerFactory.getLogger(WebManager.class);

    /** A context attribute for storing an instance of this class. */
    /*package*/ static final String ATTR_WEB_MANAGER = "javax.zkoss.zk.ui.WebManager";
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java - About 2 hrs to fix

      Method newPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static Page newPage(UiFactory uf, RequestInfo ri, PageDefinition pagedef, ServletResponse response,
            String path) {
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java - About 35 mins to fix

        Method newPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static Page newPage(UiFactory uf, RequestInfo ri, Richlet richlet, ServletResponse response, String path) {
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java - About 35 mins to fix

          Method getDesktop has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public Desktop getDesktop(Session sess, ServletRequest request, ServletResponse response, String path,
            boolean autocreate) {
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java - About 35 mins to fix

            Method addActivationListener has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static final void addActivationListener(ServletContext ctx, WebManagerActivationListener listener) {
        if (ctx == null || listener == null)
            throw new IllegalArgumentException("null");

        final WebManager webman = getWebManagerIfAny(ctx);
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getCWRURLPrefix has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private String getCWRURLPrefix() {
        final String verInfoEnabled = Library.getProperty("org.zkoss.zk.ui.versionInfo.enabled", "true");
        String build = _wapp.getBuild();
        if (!"true".equals(verInfoEnabled)) {
            return org.zkoss.zk.ui.http.Utils.obfuscateHashWithSalt(build, verInfoEnabled);
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static Page newPage(UiFactory uf, RequestInfo ri, Richlet richlet, ServletResponse response, String path) {
        final DesktopCtrl desktopCtrl = (DesktopCtrl) ri.getDesktop();
        final Execution exec = ExecutionsCtrl.getCurrent();
        TemporaryExecution de = new TemporaryExecution(ri.getWebApp().getServletContext(),
                (HttpServletRequest) ri.getNativeRequest(), (HttpServletResponse) response, ri.getDesktop());
            Severity: Major
            Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java and 1 other location - About 1 hr to fix
            zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java on lines 584..599

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static Page newPage(UiFactory uf, RequestInfo ri, PageDefinition pagedef, ServletResponse response,
            String path) {
        final DesktopCtrl desktopCtrl = (DesktopCtrl) ri.getDesktop();
        final Execution exec = ExecutionsCtrl.getCurrent();
        TemporaryExecution de = new TemporaryExecution(ri.getWebApp().getServletContext(),
            Severity: Major
            Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java and 1 other location - About 1 hr to fix
            zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java on lines 609..623

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        synchronized (WebManager.class) {
                List<WebManagerActivationListener> l = _actListeners.get(ctx);
                if (l == null)
                    _actListeners.put(ctx, l = new LinkedList<WebManagerActivationListener>());
                l.add(listener);
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/http/WebManager.java and 1 other location - About 35 mins to fix
            zk/src/main/java/org/zkoss/zk/ui/impl/UiEngineImpl.java on lines 1701..1706

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 44.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status