Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java

Summary

Maintainability
D
2 days
Test Coverage

Method getDateJavaScript has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    private static final String getDateJavaScript(Locale locale, int firstDayOfWeek) {
        final StringBuffer sb = new StringBuffer(512);
        final Calendar cal = Calendar.getInstance(locale);
        final int twoDigitYearStart = Utils.get2DigitYearStart();
        cal.clear();
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getDateJavaScript has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static final String getDateJavaScript(Locale locale, int firstDayOfWeek) {
        final StringBuffer sb = new StringBuffer(512);
        final Calendar cal = Calendar.getInstance(locale);
        final int twoDigitYearStart = Utils.get2DigitYearStart();
        cal.clear();
Severity: Major
Found in zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java - About 3 hrs to fix

    File Wpds.java has 299 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* Wpds.java

    Purpose:
        
    Description:
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java - About 3 hrs to fix

      Method outWidgetListJavaScript has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public static String outWidgetListJavaScript(String lang) {
        final StringBuffer sb = new StringBuffer(4096).append("zk.wgt.WidgetInfo.register([");

        boolean first = true;
        for (Iterator it = LanguageDefinition.lookup(lang).getComponentDefinitions().iterator(); it.hasNext();) {
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int j = firstDayOfWeek, k = 0; k < 7; ++k) {
            cal.set(Calendar.DAY_OF_WEEK, j);
            sdow[k] = df.format(cal.getTime());
            if (++j > Calendar.SATURDAY)
                j = Calendar.SUNDAY;
      Severity: Major
      Found in zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java and 1 other location - About 3 hrs to fix
      zul/src/main/java/org/zkoss/zul/Datebox.java on lines 649..662

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 206.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int j = 0; j < 12; ++j) {
            cal.set(Calendar.MONTH, j);
            smon[j] = df.format(cal.getTime());

            if (zhlang) {
      Severity: Major
      Found in zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java and 1 other location - About 3 hrs to fix
      zul/src/main/java/org/zkoss/zul/Datebox.java on lines 725..737

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 192.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int j = firstDayOfWeek, k = 0; k < 7; ++k) {
            cal.set(Calendar.DAY_OF_WEEK, j);
            fdow[k] = df.format(cal.getTime());
            if (++j > Calendar.SATURDAY)
                j = Calendar.SUNDAY;
      Severity: Major
      Found in zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java and 1 other location - About 1 hr to fix
      zul/src/main/java/org/zkoss/zul/Datebox.java on lines 716..721

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int j = 0; j < 12; ++j) {
            cal.set(Calendar.MONTH, j);
            fmon[j] = df.format(cal.getTime());
        }
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/http/Wpds.java and 1 other location - About 40 mins to fix
      zul/src/main/java/org/zkoss/zul/Datebox.java on lines 741..744

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status