Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java

Summary

Maintainability
F
4 days
Test Coverage

LanguageDefinition has 74 methods (exceeds 20 allowed). Consider refactoring.
Open

public class LanguageDefinition {
    private static final Logger log = LoggerFactory.getLogger(LanguageDefinition.class);
    //static//
    /** A map of (String name or namespace, LanguageDefinition). */
    private static final Map<String, LanguageDefinition> _ldefByName = new HashMap<String, LanguageDefinition>();
Severity: Major
Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java - About 1 day to fix

    File LanguageDefinition.java has 552 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* LanguageDefinition.java

    Purpose:
        
    Description:
    Severity: Major
    Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java - About 1 day to fix

      Method lookup has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          public static final LanguageDefinition lookup(String name) {
        init();

        if (name == null || name.length() == 0)
            name = "xul/html";
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method lookup has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static final LanguageDefinition lookup(String name) {
        init();

        if (name == null || name.length() == 0)
            name = "xul/html";
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (langnm.substring(0, j).equals(name))
                                return me.getValue();
        Severity: Major
        Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java - About 45 mins to fix

          Consider simplifying this complex logical expression.
          Open

                  if (name == null || name.length() == 0 || namespace == null || namespace.length() == 0 || pageRenderer == null
                || locator == null)
            throw new IllegalArgumentException();
          Severity: Major
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java - About 40 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public void addInitScript(String zslang, String script) {
        if (zslang == null || zslang.length() == 0)
            throw new IllegalArgumentException("null or empty language");
        if (script != null && script.length() > 0) {
            zslang = zslang.toLowerCase(java.util.Locale.ENGLISH);
            Severity: Major
            Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java and 1 other location - About 1 hr to fix
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 755..765

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 113.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public void addEachTimeScript(String zslang, String script) {
        if (zslang == null || zslang.length() == 0)
            throw new IllegalArgumentException("null or empty language");
        if (script != null && script.length() > 0) {
            zslang = zslang.toLowerCase(java.util.Locale.ENGLISH);
            Severity: Major
            Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java and 1 other location - About 1 hr to fix
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 725..735

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 113.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public void setMacroTemplate(Class<? extends Component> klass) {
        if (klass == null || !Component.class.isAssignableFrom(klass) || !Macro.class.isAssignableFrom(klass))
            throw new IllegalArgumentException("Illegal macro class: " + klass);
        _macrocls = klass;
    }
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java and 1 other location - About 40 mins to fix
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 968..972

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public void setShadowTemplate(Class<? extends Component> klass) {
        if (klass == null || !Component.class.isAssignableFrom(klass) || !ShadowElement.class.isAssignableFrom(klass))
            throw new IllegalArgumentException("Illegal shadow class: " + klass);
        _shadowcls = klass;
    }
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java and 1 other location - About 40 mins to fix
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 940..944

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (pkgFrom == null || pkgFrom.length() == 0 || pkgTo == null || pkgTo.length() == 0)
            throw new IllegalArgumentException();
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java and 2 other locations - About 30 mins to fix
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 877..878
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 1141..1142

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (name == null || name.length() == 0 || version == null || version.length() == 0)
            throw new IllegalArgumentException();
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java and 2 other locations - About 30 mins to fix
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 826..827
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 1141..1142

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (name == null || name.length() == 0 || prop == null || prop.length() == 0)
                throw new IllegalArgumentException();
            Severity: Minor
            Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java and 2 other locations - About 30 mins to fix
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 826..827
            zk/src/main/java/org/zkoss/zk/ui/metainfo/LanguageDefinition.java on lines 877..878

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status