Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java

Summary

Maintainability
D
2 days
Test Coverage

ComponentDefinitionImpl has 50 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ComponentDefinitionImpl implements ComponentDefinition, java.io.Serializable {
    private String _name;
    private transient LanguageDefinition _langdef;
    private transient PageDefinition _pgdef;
    private EvaluatorRef _evalr;
Severity: Minor
Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 7 hrs to fix

    File ComponentDefinitionImpl.java has 351 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* ComponentDefinitionImpl.java

    Purpose:
        
    Description:
    Severity: Minor
    Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 4 hrs to fix

      Method evalProperties has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public Map<String, Object> evalProperties(Map<String, Object> propmap, Page owner, Component parent) {
        if (propmap == null)
            propmap = new HashMap<String, Object>();

        if (_props != null) {
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method newMacroDefinition has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static final ComponentDefinition newMacroDefinition(LanguageDefinition langdef, PageDefinition pgdef,
            String name, Class<? extends Component> cls, String macroURI, boolean inline) {
      Severity: Minor
      Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 45 mins to fix

        Method newShadowDefinition has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static final ComponentDefinition newShadowDefinition(LanguageDefinition langdef, PageDefinition pgdef,
            String name, Class<? extends Component> cls, String templateURI) {
        Severity: Minor
        Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 35 mins to fix

          Method setDefaultWidgetClass has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public void setDefaultWidgetClass(String widgetClass) {
        final ExValue oldwc = _defWgtClass;
        _defWgtClass = new ExValue(widgetClass, String.class);

        //replace mold's widget class if it is the old default one
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method clone has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public Object clone() {
        final ComponentDefinitionImpl compdef;
        try {
            compdef = (ComponentDefinitionImpl) super.clone();
        } catch (CloneNotSupportedException ex) {
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private void init(LanguageDefinition langdef, PageDefinition pgdef, String name, Object cls) {
        if (name == null)
            throw new IllegalArgumentException();
        if (langdef != null && pgdef != null)
            throw new IllegalArgumentException("langdef and pgdef cannot both null or both non-null");
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getWidgetClass has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public String getWidgetClass(Component comp, String moldName) {
        if (_molds != null) {
            final ExValue wc = _molds.get(moldName);
            if (wc != null) {
                final String s = (String) wc.getValue(_evalr, comp);
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method newInstance has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public Component newInstance(Class<? extends Component> cls) {
        final Object curInfo = ComponentsCtrl.getCurrentInfo();
        boolean bSet = true;
        if (curInfo instanceof ComponentInfo) {
            bSet = ((ComponentInfo) curInfo).getComponentDefinition() != this;
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method resolveImplementationClass has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public Class<?> resolveImplementationClass(Page page, String clsnm) throws ClassNotFoundException {
        final Object cls = clsnm != null ? clsnm : _implcls;
        if (cls instanceof String) {
            clsnm = (String) cls;
            final Class<?> found = page != null ? page.resolveClass(clsnm) : Classes.forNameByThread(clsnm);
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public String getApply() {
        if (_apply == null)
            return null;

        final StringBuffer sb = new StringBuffer();
          Severity: Major
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java and 1 other location - About 1 hr to fix
          zk/src/main/java/org/zkoss/zk/ui/metainfo/ComponentInfo.java on lines 373..384

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 81.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (_props != null) {
            for (Property prop : _props) {
                if (parent != null) {
                    if (prop.isEffective(parent))
                        propmap.put(prop.getName(), prop.getValue(parent));
          Severity: Major
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java and 1 other location - About 1 hr to fix
          zk/src/main/java/org/zkoss/zk/ui/metainfo/ComponentInfo.java on lines 777..787

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              private void readObject(java.io.ObjectInputStream s) throws java.io.IOException, ClassNotFoundException {
        s.defaultReadObject();

        final String langnm = (String) s.readObject();
        if (langnm != null)
          Severity: Minor
          Found in zk/src/main/java/org/zkoss/zk/ui/metainfo/impl/ComponentDefinitionImpl.java and 1 other location - About 30 mins to fix
          zk/src/main/java/org/zkoss/zk/ui/metainfo/LangEvalRef.java on lines 48..54

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status