Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/resources/web/js/zk/domtouch.ts

Summary

Maintainability
F
4 days
Test Coverage

File domtouch.ts has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* domtouch.ts

    Purpose:
        Enhance/fix ios dom event
    Description:
Severity: Minor
Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 4 hrs to fix

    Function bindTapHold_ has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        bindTapHold_() {
        if (this.isListen('onRightClick') || (window.zul && this instanceof zul.Widget && this.getContext())) { //also register context menu to tapHold event
            this._holdTime = 800;
            this._startHold = (evt: JQuery.TouchEventBase): void => {
                if (!this._rightClickPending) {
    Severity: Minor
    Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function on has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        on: function (this: JQuery, type: string, selector, data: unknown, fn: unknown, ...rest: unknown[]) {
        var evtType: string | undefined;
        if ((evtType = zjq.eventTypes[type])) {
            // refer to jquery on function for reassign args
            if (data == null && fn == null) {
    Severity: Minor
    Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _dblTapStart has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        _dblTapStart(evt: JQuery.TouchStartEvent) {
        var tevt = evt.originalEvent as TouchEvent;
        if (tevt.touches.length > 1) return;
        if (!this._tapValid) {
            this._startTap!(this);
    Severity: Minor
    Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function bindTapHold_ has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        bindTapHold_() {
        if (this.isListen('onRightClick') || (window.zul && this instanceof zul.Widget && this.getContext())) { //also register context menu to tapHold event
            this._holdTime = 800;
            this._startHold = (evt: JQuery.TouchEventBase): void => {
                if (!this._rightClickPending) {
    Severity: Minor
    Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 1 hr to fix

      Function _dblTapEnd has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          _dblTapEnd(evt: JQuery.TouchEndEvent) {
        var tevt = evt.originalEvent as TouchEvent;
        if (tevt.touches.length > 1) return;
        if (this._dbTap) {
            this._dbTap = this._tapValid = false;
      Severity: Minor
      Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _removeEventFunction has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function _removeEventFunction(elem: Element, type: string, fn: CallableFunction): boolean {
    var eventFuncs = jq.data(elem, 'zk_eventFuncs') as Record<string, CallableFunction[]>,
        funcs: CallableFunction[];

    if (eventFuncs && (funcs = eventFuncs[type])) {
      Severity: Minor
      Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function on has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          on: function (this: JQuery, type: string, selector, data: unknown, fn: unknown, ...rest: unknown[]) {
      Severity: Minor
      Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 45 mins to fix

        Consider simplifying this complex logical expression.
        Open

                if (p && (!zk.isLoaded('zul.grid') || !(p instanceof zul.grid.Row))
            && (!zk.isLoaded('zul.sel') || (!(p instanceof zul.sel.Listitem) && !(p instanceof zul.sel.Treerow))))
            tevt.stopPropagation();
        Severity: Major
        Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

                  if (p && (!zk.isLoaded('zul.grid') || !(p instanceof zul.grid.Row))
            && (!zk.isLoaded('zul.sel') || (!(p instanceof zul.sel.Listitem) && !(p instanceof zul.sel.Treerow))))
        tevt.stopPropagation();
          Severity: Major
          Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 40 mins to fix

            Function off has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                off: function (this: JQuery, type: string, selector: unknown, fn: unknown, ...rest: unknown[]) {
            Severity: Minor
            Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 35 mins to fix

              Function off has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  off: function (this: JQuery, type: string, selector: unknown, fn: unknown, ...rest: unknown[]) {
        var evtType: string | undefined;
        if ((evtType = zjq.eventTypes[type])) {
            // refer to jquery on function for reassign args
            if (selector === false || typeof selector === 'function') {
              Severity: Minor
              Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _tapHoldStart has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  _tapHoldStart(evt: JQuery.TouchEventBase) {
        var tevt = evt.originalEvent as TouchEvent;

        if (tevt.touches.length > 1)
            return;
              Severity: Minor
              Found in zk/src/main/resources/web/js/zk/domtouch.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          jq(this.$n()).on('touchstart', this.proxy(this._tapHoldStart))
                .on('touchmove', this.proxy(this._tapHoldMove)) //cancel hold if moved
                .on('click', this.proxy(this._tapHoldClick))    //prevent click during hold
                .on('touchend', this.proxy(this._tapHoldEnd));
              Severity: Major
              Found in zk/src/main/resources/web/js/zk/domtouch.ts and 1 other location - About 3 hrs to fix
              zk/src/main/resources/web/js/zk/domtouch.ts on lines 279..282

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          jq(this.$n()).off('touchstart', this.proxy(this._tapHoldStart))
                .off('touchmove', this.proxy(this._tapHoldMove)) //cancel hold if moved
                .off('click', this.proxy(this._tapHoldClick))    //prevent click during hold
                .off('touchend', this.proxy(this._tapHoldEnd));
              Severity: Major
              Found in zk/src/main/resources/web/js/zk/domtouch.ts and 1 other location - About 3 hrs to fix
              zk/src/main/resources/web/js/zk/domtouch.ts on lines 269..272

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (p && (!zk.isLoaded('zul.grid') || !(p instanceof zul.grid.Row))
            && (!zk.isLoaded('zul.sel') || (!(p instanceof zul.sel.Listitem) && !(p instanceof zul.sel.Treerow))))
        tevt.stopPropagation();
              Severity: Major
              Found in zk/src/main/resources/web/js/zk/domtouch.ts and 1 other location - About 3 hrs to fix
              zk/src/main/resources/web/js/zk/domtouch.ts on lines 298..300

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (p && (!zk.isLoaded('zul.grid') || !(p instanceof zul.grid.Row))
            && (!zk.isLoaded('zul.sel') || (!(p instanceof zul.sel.Listitem) && !(p instanceof zul.sel.Treerow))))
            tevt.stopPropagation();
              Severity: Major
              Found in zk/src/main/resources/web/js/zk/domtouch.ts and 1 other location - About 3 hrs to fix
              zk/src/main/resources/web/js/zk/domtouch.ts on lines 212..214

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          jq(this.$n()).on('touchstart', this.proxy(this._dblTapStart))
                .on('touchend', this.proxy(this._dblTapEnd));
              Severity: Major
              Found in zk/src/main/resources/web/js/zk/domtouch.ts and 1 other location - About 1 hr to fix
              zk/src/main/resources/web/js/zk/domtouch.ts on lines 191..192

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          jq(this.$n()).off('touchstart', this.proxy(this._dblTapStart))
                .off('touchend', this.proxy(this._dblTapEnd));
              Severity: Major
              Found in zk/src/main/resources/web/js/zk/domtouch.ts and 1 other location - About 1 hr to fix
              zk/src/main/resources/web/js/zk/domtouch.ts on lines 183..184

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status