Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/resources/web/js/zk/effect.ts

Summary

Maintainability
F
3 days
Test Coverage

File effect.ts has 419 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* effect.ts

    Purpose:

    Description:
Severity: Minor
Found in zk/src/main/resources/web/js/zk/effect.ts - About 6 hrs to fix

    Function sync has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

            sync(): void {
            var opts = this._opts,
                anchor = opts.anchor,
                $anchor = zk(anchor);
    Severity: Minor
    Found in zk/src/main/resources/web/js/zk/effect.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructor has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

            constructor(opts: EffectFullMaskOptions) {
            super();
            opts = eff._skuOpts(opts);
            var mask = this.mask = jq(opts.mask || [], zk)[0];
            if (this.mask) {
    Severity: Minor
    Found in zk/src/main/resources/web/js/zk/effect.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sync has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            sync(): void {
            var opts = this._opts,
                anchor = opts.anchor,
                $anchor = zk(anchor);
    Severity: Major
    Found in zk/src/main/resources/web/js/zk/effect.ts - About 2 hrs to fix

      Function sync has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

              sync(): boolean {
            var node = this.node, $node = jq(node);
            if (!node || !$node.zk.isVisible(true)) {
                if (this.opts.stackup && node) {
                    if (!this.stackup)
      Severity: Minor
      Found in zk/src/main/resources/web/js/zk/effect.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _draw has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _draw(opts: EffectMaskOptions, $anchor: zk.JQZK): void {
            var maskId = opts.id || 'z_applymask',
                progbox = jq(maskId, zk)[0];

            if (progbox) return;
      Severity: Minor
      Found in zk/src/main/resources/web/js/zk/effect.ts - About 1 hr to fix

        Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                constructor(opts: EffectFullMaskOptions) {
            super();
            opts = eff._skuOpts(opts);
            var mask = this.mask = jq(opts.mask || [], zk)[0];
            if (this.mask) {
        Severity: Minor
        Found in zk/src/main/resources/web/js/zk/effect.ts - About 1 hr to fix

          Function sync has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  sync(): boolean {
            var node = this.node, $node = jq(node);
            if (!node || !$node.zk.isVisible(true)) {
                if (this.opts.stackup && node) {
                    if (!this.stackup)
          Severity: Minor
          Found in zk/src/main/resources/web/js/zk/effect.ts - About 1 hr to fix

            Function sync has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                    sync(el?: HTMLElement): void {
            if (el === undefined || !zk(el).isVisible(true)) {
                this.hide();
                return;
            }
            Severity: Minor
            Found in zk/src/main/resources/web/js/zk/effect.ts - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    slideUp(this: zk.Widget, n: HTMLElement, opts?: zk.SlideOptions): void {
            zk(n).slideUp(this, opts);
        },
            Severity: Major
            Found in zk/src/main/resources/web/js/zk/effect.ts and 3 other locations - About 1 hr to fix
            zk/src/main/resources/web/js/zk/effect.ts on lines 435..437
            zk/src/main/resources/web/js/zk/effect.ts on lines 457..459
            zk/src/main/resources/web/js/zk/effect.ts on lines 468..470

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    slideOut(this: zk.Widget, n: HTMLElement, opts?: zk.SlideOptions): void {
            zk(n).slideOut(this, opts);
        }
            Severity: Major
            Found in zk/src/main/resources/web/js/zk/effect.ts and 3 other locations - About 1 hr to fix
            zk/src/main/resources/web/js/zk/effect.ts on lines 435..437
            zk/src/main/resources/web/js/zk/effect.ts on lines 446..448
            zk/src/main/resources/web/js/zk/effect.ts on lines 457..459

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    slideDown(this: zk.Widget, n: HTMLElement, opts?: zk.SlideOptions): void {
            zk(n).slideDown(this, opts);
        },
            Severity: Major
            Found in zk/src/main/resources/web/js/zk/effect.ts and 3 other locations - About 1 hr to fix
            zk/src/main/resources/web/js/zk/effect.ts on lines 446..448
            zk/src/main/resources/web/js/zk/effect.ts on lines 457..459
            zk/src/main/resources/web/js/zk/effect.ts on lines 468..470

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    slideIn(this: zk.Widget, n: HTMLElement, opts?: zk.SlideOptions): void {
            zk(n).slideIn(this, opts);
        },
            Severity: Major
            Found in zk/src/main/resources/web/js/zk/effect.ts and 3 other locations - About 1 hr to fix
            zk/src/main/resources/web/js/zk/effect.ts on lines 435..437
            zk/src/main/resources/web/js/zk/effect.ts on lines 446..448
            zk/src/main/resources/web/js/zk/effect.ts on lines 468..470

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (loading.offsetHeight > h)
                    loading.style.height = jq.px0(zk(loading).revisedHeight(h));
            Severity: Minor
            Found in zk/src/main/resources/web/js/zk/effect.ts and 1 other location - About 35 mins to fix
            zk/src/main/resources/web/js/zk/effect.ts on lines 394..395

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (loading.offsetWidth > w)
                    loading.style.width = jq.px0(zk(loading).revisedWidth(w));
            Severity: Minor
            Found in zk/src/main/resources/web/js/zk/effect.ts and 1 other location - About 35 mins to fix
            zk/src/main/resources/web/js/zk/effect.ts on lines 392..393

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status