Sign upLogin

zkoss/zk

View on GitHub
Star
zk/src/main/resources/web/js/zk/pkg.ts

Summary

Maintainability
D
1 day
Test Coverage

Function afterLoad has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

export function afterLoad(a: string | CallableFunction, b?: CallableFunction, front?: boolean): boolean | void {
    if (typeof a == 'string') {
        if (!b) return true;

        for (var pkgs = a.split(','), j = pkgs.length; j--;) {
Severity: Minor
Found in zk/src/main/resources/web/js/zk/pkg.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setLoaded has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

export function setLoaded(pkg: string, wait?: boolean): void { //internal
    _xloadings.$remove(pkg);
    _loading[pkg] = true;

    if (wait) {
Severity: Minor
Found in zk/src/main/resources/web/js/zk/pkg.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setHost has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

export function setHost(host: string, resURI: string, pkgs: string[]): void {
    var hostRes = host + resURI;
    if (!_defhost.length)
        for (var scs = document.getElementsByTagName('script'), j = 0, len = scs.length;
        j < len; ++j) {
Severity: Minor
Found in zk/src/main/resources/web/js/zk/pkg.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function afterLoad has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function afterLoad(a: string | CallableFunction, b?: CallableFunction, front?: boolean): boolean | void {
    if (typeof a == 'string') {
        if (!b) return true;

        for (var pkgs = a.split(','), j = pkgs.length; j--;) {
Severity: Minor
Found in zk/src/main/resources/web/js/zk/pkg.ts - About 1 hr to fix

    Function setLoaded has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function setLoaded(pkg: string, wait?: boolean): void { //internal
    _xloadings.$remove(pkg);
    _loading[pkg] = true;

    if (wait) {
    Severity: Minor
    Found in zk/src/main/resources/web/js/zk/pkg.ts - About 1 hr to fix

      Function depends has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function depends(a: string, b: string): void {
    if (a && b) {//a depends on b
        if (_loaded[a])
            zk.load(b);
        else {
      Severity: Minor
      Found in zk/src/main/resources/web/js/zk/pkg.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function load has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function load(pkg: string, dt?: zk.Desktop | CallableFunction, func?: CallableFunction): boolean {
    if (typeof dt == 'function') {
        if (func)
            throw 'At most one function allowed';
        else {
      Severity: Minor
      Found in zk/src/main/resources/web/js/zk/pkg.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                          if (p2 && !_loaded[p2]) { //yes, more
                        var a1 = a, b1 = b;
                        b = function () {
                            zk.afterLoad(a1, b1, front); //check again
                        };
      Severity: Major
      Found in zk/src/main/resources/web/js/zk/pkg.ts - About 45 mins to fix

        Function loadScript has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export function loadScript(src: string, name?: string, charset?: string, force?: boolean, callback?: CallableFunction): void { // FIXME: return ZKCoreUtilityStatic;
        Severity: Minor
        Found in zk/src/main/resources/web/js/zk/pkg.ts - About 35 mins to fix

          Function getHost has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          export function getHost(pkg: string, js: boolean): string {
    for (var p in _pkghosts)
        if (pkg.startsWith(p))
            return _pkghosts[p][js ? 1 : 0];
    return _defhost[js ? 1 : 0];
          Severity: Minor
          Found in zk/src/main/resources/web/js/zk/pkg.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            zk.enableESC();
        } catch (ex) {
            zk.debugLog((ex as Error).message ?? ex);
        }
          Severity: Minor
          Found in zk/src/main/resources/web/js/zk/pkg.ts and 1 other location - About 40 mins to fix
          zk/src/main/resources/web/js/zk/dom.ts on lines 109..113

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status