Sign upLogin

zkoss/zk

View on GitHub
Star
zkbind/src/main/java/org/zkoss/bind/impl/BindTabboxRenderer.java

Summary

Maintainability
D
2 days
Test Coverage

Method renderTab has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void renderTab(Tab item, final Object data, final int index) throws Exception {
        final Tabbox tabbox = item.getTabbox();
        final Tabs tabs = tabbox.getTabs();
        final int size = tabbox.getModel().getSize();
        final String tmn = "model";
Severity: Major
Found in zkbind/src/main/java/org/zkoss/bind/impl/BindTabboxRenderer.java - About 2 hrs to fix

    Method renderTab has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        public void renderTab(Tab item, final Object data, final int index) throws Exception {
        final Tabbox tabbox = item.getTabbox();
        final Tabs tabs = tabbox.getTabs();
        final int size = tabbox.getModel().getSize();
        final String tmn = "model";
    Severity: Minor
    Found in zkbind/src/main/java/org/zkoss/bind/impl/BindTabboxRenderer.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method renderTabpanel has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void renderTabpanel(Tabpanel item, final Object data, final int index) throws Exception {
        final Tabbox tabbox = item.getTabbox();
        final Tabpanels tabpanels = tabbox.getTabpanels();
        final int size = tabbox.getModel().getSize();
        final String tmn = "model";
    Severity: Major
    Found in zkbind/src/main/java/org/zkoss/bind/impl/BindTabboxRenderer.java - About 2 hrs to fix

      Method renderTabpanel has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public void renderTabpanel(Tabpanel item, final Object data, final int index) throws Exception {
        final Tabbox tabbox = item.getTabbox();
        final Tabpanels tabpanels = tabbox.getTabpanels();
        final int size = tabbox.getModel().getSize();
        final String tmn = "model";
      Severity: Minor
      Found in zkbind/src/main/java/org/zkoss/bind/impl/BindTabboxRenderer.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (tm == null) {
            item.setLabel(Objects.toString(data));
            item.setValue(data);
        } else {
            final ForEachStatus iterStatus = new AbstractForEachStatus() { //provide iteration status in this context
      Severity: Major
      Found in zkbind/src/main/java/org/zkoss/bind/impl/BindTabboxRenderer.java and 1 other location - About 7 hrs to fix
      zkbind/src/main/java/org/zkoss/bind/impl/BindRadioRenderer.java on lines 43..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 470.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status