Sign upLogin

zkoss/zk

View on GitHub
Star
zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java

Summary

Maintainability
F
3 days
Test Coverage

File ParamCall.java has 406 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package org.zkoss.bind.impl;

import java.beans.BeanInfo;
import java.beans.Introspector;
import java.beans.PropertyDescriptor;
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 5 hrs to fix

    Method resolveParameter has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        protected Object resolveParameter(Annotation[] parmAnnos, Class<?> paramType, Method method, int index) {
        Object val = null;
        boolean hitResolver = false;
        Default defAnno = null;
        for (Annotation anno : parmAnnos) {
    Severity: Minor
    Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    ParamCall has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class ParamCall {

    private static final Logger _log = LoggerFactory.getLogger(ParamCall.class);
    private static final Paranamer _PARANAMER = new CachingParanamer(new AdaptiveParanamer());
    Severity: Minor
    Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 2 hrs to fix

      Method get has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

              public Object get(ContextType type) {
            switch (type) {
            //bind contexts
            case BIND_CONTEXT:
                return _bindContext;
      Severity: Minor
      Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setComponent has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void setComponent(Component comp) {
        _component = comp;
        //scope param
        _paramResolvers.put(ScopeParam.class, new ParamResolver<Annotation>() {
      Severity: Minor
      Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 1 hr to fix

        Method resolvePositionalOrNoAnnoParameter has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            private Object resolvePositionalOrNoAnnoParameter(Class<?> returnType, Method method, int index) {
        Object val = null;
        if (_bindingArgs != null) {
            int argIndex = 0;
            for (Map.Entry<String, Object> entry : _bindingArgs.entrySet()) {
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method setExecution has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void setExecution(Execution exec) {
        _execution = exec;
        //http param
        _paramResolvers.put(QueryParam.class, new ParamResolver<Annotation>() {
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 1 hr to fix

          Method resolveParameter has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected Object resolveParameter(Annotation[] parmAnnos, Class<?> paramType, Method method, int index) {
        Object val = null;
        boolean hitResolver = false;
        Default defAnno = null;
        for (Annotation anno : parmAnnos) {
          Severity: Minor
          Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 1 hr to fix

            Method resolveParameter0 has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                protected Object resolveParameter0(Object val, Class<?> returnType) {
        if (val != null && returnType.isAssignableFrom(val.getClass())) { //escape
            return val;
        } else if (Component.class.isAssignableFrom(returnType) && val instanceof String) {
            return _root.getDesktop().getComponentByUuidIfAny((String) val);
            Severity: Minor
            Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method setBindingArgs has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void setBindingArgs(final Map<String, Object> bindingArgs) {
        this._bindingArgs = bindingArgs;
        _paramResolvers.put(BindingParam.class, new ParamResolver<Annotation>() {
            public Object resolveParameter(Annotation anno, Class<?> returnType, Supplier<String> parameterName) {
                Object val = bindingArgs.get(getAnnotatedParameterName(BindingParam.class, ((BindingParam) anno).value(), parameterName));
            Severity: Minor
            Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 1 hr to fix

              Method get has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      public Object get(ContextType type) {
            switch (type) {
            //bind contexts
            case BIND_CONTEXT:
                return _bindContext;
              Severity: Minor
              Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 1 hr to fix

                Method call has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public void call(Object base, Method method) {
        Method originalMethod = ViewModelAnnotationResolvers.getOriginalMethod(base, method);
        Class<?>[] paramTypes = originalMethod.getParameterTypes();
        java.lang.annotation.Annotation[][] parmAnnos = originalMethod.getParameterAnnotations();
        Object[] params = new Object[paramTypes.length];
                Severity: Minor
                Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                            return _root.getDesktop().getComponentByUuidIfAny((String) val);
                Severity: Major
                Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return val;
                  Severity: Major
                  Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java - About 30 mins to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            _paramResolvers.put(QueryParam.class, new ParamResolver<Annotation>() {

            public Object resolveParameter(Annotation anno, Class<?> returnType, Supplier<String> parameterName) {
                Object val = _execution.getParameter(getAnnotatedParameterName(QueryParam.class, ((QueryParam) anno).value(), parameterName));
                return val == null ? null : Classes.coerce(returnType, val);
                    Severity: Major
                    Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java and 2 other locations - About 50 mins to fix
                    zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java on lines 401..407
                    zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java on lines 435..441

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 60.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            _paramResolvers.put(ExecutionParam.class, new ParamResolver<Annotation>() {

            public Object resolveParameter(Annotation anno, Class<?> returnType, Supplier<String> parameterName) {
                Object val = _execution.getAttribute(getAnnotatedParameterName(ExecutionParam.class, ((ExecutionParam) anno).value(), parameterName));
                return val == null ? null : Classes.coerce(returnType, val);
                    Severity: Major
                    Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java and 2 other locations - About 50 mins to fix
                    zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java on lines 394..400
                    zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java on lines 401..407

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 60.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            _paramResolvers.put(HeaderParam.class, new ParamResolver<Annotation>() {

            public Object resolveParameter(Annotation anno, Class<?> returnType, Supplier<String> parameterName) {
                Object val = _execution.getHeader(getAnnotatedParameterName(HeaderParam.class, ((HeaderParam) anno).value(), parameterName));
                return val == null ? null : Classes.coerce(returnType, val);
                    Severity: Major
                    Found in zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java and 2 other locations - About 50 mins to fix
                    zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java on lines 394..400
                    zkbind/src/main/java/org/zkoss/bind/impl/ParamCall.java on lines 435..441

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 60.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status