Sign upLogin

zkoss/zk

View on GitHub
Star
zkbind/src/main/java/org/zkoss/bind/impl/SaveFormBindingImpl.java

Summary

Maintainability
D
1 day
Test Coverage

Method save has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    public void save(BindContext ctx) {
        final Binder binder = getBinder();
        final Component comp = getComponent(); //ctx.getComponent();
        final Form form = getFormBean(ctx);
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/impl/SaveFormBindingImpl.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void save(BindContext ctx) {
        final Binder binder = getBinder();
        final Component comp = getComponent(); //ctx.getComponent();
        final Form form = getFormBean(ctx);
Severity: Major
Found in zkbind/src/main/java/org/zkoss/bind/impl/SaveFormBindingImpl.java - About 2 hrs to fix

    Method getValidates has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public Set<Property> getValidates(BindContext ctx) {
        final Set<Property> properties = new HashSet<Property>(2);
        //we should not check this binding need to validate or not here, 
        //since other validator may want to know the value of porperty of this binding, so just provide it 
        final Binder binder = getBinder();
    Severity: Minor
    Found in zkbind/src/main/java/org/zkoss/bind/impl/SaveFormBindingImpl.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getValidates has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public Set<Property> getValidates(BindContext ctx) {
        final Set<Property> properties = new HashSet<Property>(2);
        //we should not check this binding need to validate or not here, 
        //since other validator may want to know the value of porperty of this binding, so just provide it 
        final Binder binder = getBinder();
    Severity: Minor
    Found in zkbind/src/main/java/org/zkoss/bind/impl/SaveFormBindingImpl.java - About 1 hr to fix

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

          private String getConditionString(BindContext ctx) {
        StringBuilder condition = new StringBuilder();
        if (getConditionType() == ConditionType.BEFORE_COMMAND) {
            condition.append("before = '").append(getCommandName()).append("'");
        } else if (getConditionType() == ConditionType.AFTER_COMMAND) {
      Severity: Major
      Found in zkbind/src/main/java/org/zkoss/bind/impl/SaveFormBindingImpl.java and 3 other locations - About 1 hr to fix
      zkbind/src/main/java/org/zkoss/bind/impl/LoadChildrenBindingImpl.java on lines 132..142
      zkbind/src/main/java/org/zkoss/bind/impl/LoadFormBindingImpl.java on lines 143..153
      zkbind/src/main/java/org/zkoss/bind/impl/LoadPropertyBindingImpl.java on lines 100..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public Validator getValidator() {
        if (_validator == null)
            return null;

        //        final BindContext ctx = BindContextUtil.newBindContext(getBinder(), this, false, null, getComponent(), null);
      Severity: Major
      Found in zkbind/src/main/java/org/zkoss/bind/impl/SaveFormBindingImpl.java and 1 other location - About 1 hr to fix
      zkbind/src/main/java/org/zkoss/bind/impl/SavePropertyBindingImpl.java on lines 95..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (collector != null) {
            collector.addInfo(new ValidationInfo(ValidationInfo.PROP, getComponent(), getValidatorExpressionString(),
                    validator.toString(), Boolean.valueOf(vctx.isValid()),
                    ((BindContextImpl) vctx.getBindContext()).getValidatorArgs(), null));
        }
      Severity: Minor
      Found in zkbind/src/main/java/org/zkoss/bind/impl/SaveFormBindingImpl.java and 1 other location - About 40 mins to fix
      zkbind/src/main/java/org/zkoss/bind/impl/SavePropertyBindingImpl.java on lines 259..263

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status