zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java

Summary

Maintainability
F
4 days
Test Coverage

Method invoke has a Cognitive Complexity of 132 (exceeds 5 allowed). Consider refactoring.
Open

    public Object invoke(Object self, Method method, Method proceed, Object[] args) throws Exception {
        try {
            final String mname = method.getName();
            if (mname.equals("hashCode")) {
                int a = (_origin != null) ? (Integer) method.invoke(_origin, args) : 0;
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method invoke has 125 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Object invoke(Object self, Method method, Method proceed, Object[] args) throws Exception {
        try {
            final String mname = method.getName();
            if (mname.equals("hashCode")) {
                int a = (_origin != null) ? (Integer) method.invoke(_origin, args) : 0;
Severity: Major
Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 5 hrs to fix

    Method isHandled has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            public boolean isHandled(Method m) {
                if (m.isAnnotationPresent(Transient.class))
                    return false;
                final String name = m.getName();
                if ("hashCode".equals(name) || "equals".equals(name))
    Severity: Minor
    Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                                if (_dirtyFieldNames != null && _dirtyFieldNames.contains(me.getKey())) {
                                    final String setter = ProxyHelper.toSetter(me.getKey());
                                    try {
                                        final Method m = Classes.getMethodByObject(_origin.getClass(), setter,
                                                new Object[] { value });
    Severity: Major
    Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if (value instanceof FormProxyObject) {
                                      ((FormProxyObject) value).submitToOrigin((BindContext) args[0]);
                                  }
      Severity: Major
      Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 45 mins to fix

        Avoid too many return statements within this method.
        Open

                        return false;
        Severity: Major
        Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return true;
          Severity: Major
          Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return false;
            Severity: Major
            Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                          return _cache.get(attr);
              Severity: Major
              Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                        return null;
                Severity: Major
                Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return _origin;
                  Severity: Major
                  Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return method.invoke(_origin, args);
                    Severity: Major
                    Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return dirty;
                      Severity: Major
                      Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return null;
                        Severity: Major
                        Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                          return proxyIfAny;
                          Severity: Major
                          Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return null;
                            Severity: Major
                            Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                  return value;
                              Severity: Major
                              Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return args.length == 1 && args[0] == null;
                                Severity: Major
                                Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                              return cacheData;
                                  Severity: Major
                                  Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java - About 30 mins to fix

                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                                if (ProxyHelper.isAttribute(m)) {
                                                    if (name.startsWith("set"))
                                                        return isSetMethodHandled(m);
                                                    if (name.startsWith("get") || name.startsWith("is"))
                                                        return true;
                                    Severity: Minor
                                    Found in zkbind/src/main/java/org/zkoss/bind/proxy/BeanProxyHandler.java and 1 other location - About 35 mins to fix
                                    zkbind/src/main/java/org/zkoss/bind/proxy/FormProxyHandler.java on lines 51..56

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 44.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    There are no issues that match your filters.

                                    Category
                                    Status