Sign upLogin

zkoss/zk

View on GitHub
Star
zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java

Summary

Maintainability
D
2 days
Test Coverage

Method createProxyIfAny has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings({ "unchecked", "rawtypes" })
    public static <T> T createProxyIfAny(T origin, Annotation[] annotations) {
        if (origin == null)
            return null;
        if (origin instanceof FormProxyObject) {
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ProxyHelper.java has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/** ProxyHelper.java.

    Purpose:

    Description:
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 2 hrs to fix

    Method createProxyIfAny has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @SuppressWarnings({ "unchecked", "rawtypes" })
    public static <T> T createProxyIfAny(T origin, Annotation[] annotations) {
        if (origin == null)
            return null;
        if (origin instanceof FormProxyObject) {
    Severity: Major
    Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 2 hrs to fix

      Method createFormProxy has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @SuppressWarnings({ "unchecked", "rawtypes" })
    public static <T> T createFormProxy(T origin, Class<?> type, Class[] interfaces) {

        if (origin instanceof Form)
            return origin;
      Severity: Minor
      Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 1 hr to fix

        Method createFormProxy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            @SuppressWarnings({ "unchecked", "rawtypes" })
    public static <T> T createFormProxy(T origin, Class<?> type, Class[] interfaces) {

        if (origin instanceof Form)
            return origin;
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cacheSavePropertyBinding has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            /* package */static void cacheSavePropertyBinding(ProxyNode node, String property, SavePropertyBinding savePropertyBinding) {
        while (node != null) {
            ProxyNode parent = node.getParent();
            if (parent == null) {
                node.getCachedSavePropertyBinding().add(new Pair<>(property, savePropertyBinding));
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method isAttribute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static boolean isAttribute(Method method) {
        if (!Modifier.isPublic(method.getModifiers()))
            return false;

        final String nm = method.getName();
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return (T) new ListModelListProxy((ListModelList) origin, annotations);
        Severity: Major
        Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return _proxyDecorator != null ? (T) _proxyDecorator.decorate((ProxyObject) p1) : (T) p1;
          Severity: Major
          Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return (T) new SetProxy((Set) origin, annotations);
            Severity: Major
            Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return (T) new ListProxy((List) origin, annotations);
              Severity: Major
              Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return (T) new ListModelArrayProxy((ListModelArray) origin, annotations);
                Severity: Major
                Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return (T) new ListProxy((Collection) origin, annotations);
                  Severity: Major
                  Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return (T) new MapProxy((Map) origin, annotations);
                    Severity: Major
                    Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return (T) new ListModelMapProxy((ListModelMap) origin, annotations);
                      Severity: Major
                      Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return (T) new ListModelSetProxy((ListModelSet) origin, annotations);
                        Severity: Major
                        Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java - About 30 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (classes != null && !classes.isEmpty()) {
            for (String className : classes) {
                try {
                    addIgnoredProxyClass(Classes.forNameByThread(className.trim()));
                } catch (ClassNotFoundException ex) {
                          Severity: Minor
                          Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java and 1 other location - About 50 mins to fix
                          zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java on lines 68..76

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (superClasses != null && !superClasses.isEmpty()) {
            for (String className : superClasses) {
                try {
                    addIgnoredSuperProxyClass(Classes.forNameByThread(className.trim()));
                } catch (ClassNotFoundException ex) {
                          Severity: Minor
                          Found in zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java and 1 other location - About 50 mins to fix
                          zkbind/src/main/java/org/zkoss/bind/proxy/ProxyHelper.java on lines 58..66

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status