Sign upLogin

zkoss/zk

View on GitHub
Star
zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java

Summary

Maintainability
D
1 day
Test Coverage

Method reInitBinder0 has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    private boolean reInitBinder0(Component comp) {
        //ZK-611 have wrong binding on a removed treecell in a template
        //if it was detached, ignore it
        if (comp.getPage() == null && !(comp instanceof ShadowElement)) {
            return false;
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File BindUiLifeCycle.java has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* BindUiLifeCycle.java

    Purpose:
        
    Description:
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 2 hrs to fix

    Method reInitBinder0 has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private boolean reInitBinder0(Component comp) {
        //ZK-611 have wrong binding on a removed treecell in a template
        //if it was detached, ignore it
        if (comp.getPage() == null && !(comp instanceof ShadowElement)) {
            return false;
    Severity: Minor
    Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 1 hr to fix

      Method handleComponentAttached has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected void handleComponentAttached(Component comp) {
        //ZK-2022, check if this component is in queue for removal 
        //if yes, then post and do processing later
        boolean removeMark = Boolean.TRUE.equals(comp.getAttribute(REMOVE_MARK));
        if (removeMark) {
      Severity: Minor
      Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 1 hr to fix

        Method removeBindings0 has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private void removeBindings0(Component comp, Map<Binder, Set<Component>> batchRemove) {
        //A component with renderer; might need to remove $MODEL$
        final Object installed = comp.removeAttribute(BinderImpl.RENDERER_INSTALLED);
        if (installed != null) {
            BindELContext.removeModel(comp);
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method reInitBinder has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private void reInitBinder(Component comp) {
        boolean recursive = reInitBinder0(comp);
        if (recursive && !(comp instanceof ShadowElement)) {
            for (final Component kid : comp.getChildren()) {
                if (kid != null) {
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method removeBindingsRecursively has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private void removeBindingsRecursively(Component comp, Map<Binder, Set<Component>> batchRemove) {
        removeBindings0(comp, batchRemove);
        for (final Iterator<Component> it = comp.getChildren().iterator(); it.hasNext();) {
            final Component kid = it.next();
            if (kid != null) {
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method handleComponentAttached has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected void handleComponentAttached(Component comp) {
        //ZK-2022, check if this component is in queue for removal 
        //if yes, then post and do processing later
        boolean removeMark = Boolean.TRUE.equals(comp.getAttribute(REMOVE_MARK));
        if (removeMark) {
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return false;
        Severity: Major
        Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private static class ExtensionHolder {
        private static final Extension INSTANCE = initializeExtension();

        private static Extension initializeExtension() {
            String clsnm = Library.getProperty("org.zkoss.bind.tracker.impl.extension");
          Severity: Minor
          Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java and 1 other location - About 1 hr to fix
          zk/src/main/java/org/zkoss/zk/ui/impl/UiEngineImpl.java on lines 695..709

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (batchRemove != null) {
                //ZK-2224 batch remove component and it kids to enhance performance.
                Set<Component> components = batchRemove.get(binder);
                if (components == null) {
                    batchRemove.put(binder, components = new LinkedHashSet<Component>());
          Severity: Minor
          Found in zkbind/src/main/java/org/zkoss/bind/tracker/impl/BindUiLifeCycle.java and 1 other location - About 35 mins to fix
          zkbind/src/main/java/org/zkoss/bind/impl/ValidationMessagesImpl.java on lines 238..244

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status