Sign upLogin

zkoss/zk

View on GitHub
Star
zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java

Summary

Maintainability
F
4 days
Test Coverage

Method getNotifys has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public static Set<Property> getNotifys(Method m, Object base, String prop, Object value, BindContext ctx) {
        //TODO, Dennis, do we really need to pass value here?
        final Set<Property> notifys = new LinkedHashSet<Property>();
        if (m == null)
            return notifys;
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

BindELContext has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

public class BindELContext extends XelELContext {
    public BindELContext(XelContext xelc) {
        super(xelc);
    }
Severity: Minor
Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 3 hrs to fix

    File BindELContext.java has 310 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* BindELContext.java

    Purpose:
        
    Description:
    Severity: Minor
    Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 3 hrs to fix

      Method getNotifys has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static Set<Property> getNotifys(Method m, Object base, String prop, Object value, BindContext ctx) {
        //TODO, Dennis, do we really need to pass value here?
        final Set<Property> notifys = new LinkedHashSet<Property>();
        if (m == null)
            return notifys;
      Severity: Minor
      Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 1 hr to fix

        Method toNodeString has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public static String toNodeString(Node next, StringBuffer path) {
        if (next instanceof AstBracketSuffix) {
            final String bracketString = toNodeString(next.jjtGetChild(0), new StringBuffer()); //recursive
            path.append("[").append(bracketString).append("]");
        } else if (next instanceof AstValue) {
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method toNodeString has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public static String toNodeString(Node next, StringBuilder path) {
        if (next instanceof AstBracketSuffix) {
            final String bracketString = toNodeString(next.jjtGetChild(0), new StringBuilder()); //recursive
            path.append("[").append(bracketString).append("]");
        } else if (next instanceof AstValue) {
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method addDependsOnTrackings has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public static void addDependsOnTrackings(Method m, String basepath, List<String> srcpath, Binding binding,
            BindContext ctx) {
        final DependsOn annt = ViewModelAnnotationResolvers.getAnnotation(m, DependsOn.class);
        if (annt != null) {
            String[] props = annt.value();
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method addNotifys has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static void addNotifys(Method m, Object base, String prop, Object value, BindContext ctx) {
        Severity: Minor
        Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 35 mins to fix

          Method addDependsOnTracking has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static void addDependsOnTracking(Binding srcBinding, List<String> srcPath, Component srcComp,
            String dependsOnPath, Component dependsOnComp) {
          Severity: Minor
          Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 35 mins to fix

            Method getNotifys has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static Set<Property> getNotifys(Method m, Object base, String prop, Object value, BindContext ctx) {
            Severity: Minor
            Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 35 mins to fix

              Method addDependsOnTrackings has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static void addDependsOnTrackings(Method m, String basepath, List<String> srcpath, Binding binding,
            BindContext ctx) {
              Severity: Minor
              Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 35 mins to fix

                Method prepareProperty has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static Property prepareProperty(Object base, String prop, Object value, BindContext ctx) {
        if (ctx != null && prop.indexOf('[') >= 0) { //handle properties that containing [] indirect reference
            final Binder binder = ctx.getBinder();
            final Component comp = ctx.getComponent();
            Object old = null;
                Severity: Minor
                Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static String toNodeString(Node next, StringBuffer path) {
        if (next instanceof AstBracketSuffix) {
            final String bracketString = toNodeString(next.jjtGetChild(0), new StringBuffer()); //recursive
            path.append("[").append(bracketString).append("]");
        } else if (next instanceof AstValue) {
                Severity: Major
                Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java and 1 other location - About 3 hrs to fix
                zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java on lines 234..258

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 233.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static String toNodeString(Node next, StringBuilder path) {
        if (next instanceof AstBracketSuffix) {
            final String bracketString = toNodeString(next.jjtGetChild(0), new StringBuilder()); //recursive
            path.append("[").append(bracketString).append("]");
        } else if (next instanceof AstValue) {
                Severity: Major
                Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java and 1 other location - About 3 hrs to fix
                zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java on lines 260..284

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 233.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static void addNotifys(Set<Property> props, BindContext ctx) {
        if (ctx == null) {
            return;
        }
        Set<Property> notifys = getNotifys(ctx);
                Severity: Minor
                Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java and 1 other location - About 55 mins to fix
                zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java on lines 221..232

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    @SuppressWarnings("unused")
    private static void addValidates(Set<Property> props, BindContext ctx) {
        if (ctx == null) {
            return;
        }
                Severity: Minor
                Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java and 1 other location - About 55 mins to fix
                zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java on lines 203..213

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (annt != null && anntdis != null) {
            throw new UiException(
                    "don't use " + NotifyChange.class + " with " + NotifyChangeDisabled.class + ", choose only one");
        }
                Severity: Minor
                Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java and 1 other location - About 30 mins to fix
                zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java on lines 141..144

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (sannt != null && anntdis != null) {
            throw new UiException("don't use " + SmartNotifyChange.class + " with " + NotifyChangeDisabled.class
                    + ", choose only one");
        }
                Severity: Minor
                Found in zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java and 1 other location - About 30 mins to fix
                zkbind/src/main/java/org/zkoss/bind/xel/zel/BindELContext.java on lines 137..140

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status