Sign upLogin

zkoss/zk

View on GitHub
Star
zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java

Summary

Maintainability
F
6 days
Test Coverage

File ModelProvider.java has 446 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* ModelProvider.java

    Purpose:
        
    Description:
Severity: Minor
Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java - About 6 hrs to fix

    Method getBeanDefaultTreeModel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            public static DefaultTreeModel getBeanDefaultTreeModel(int level1, int level2, int level3, String label) {
            Random rand = new Random(new Random().nextLong());
            Calendar cal = Calendar.getInstance();
            List list = new ArrayList(level1);
            for (int i = 0; i < level1; i++) {
    Severity: Minor
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getArrayDefaultTreeModel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            public static DefaultTreeModel getArrayDefaultTreeModel(int level1, int level2, int level3, String label) {
            Random rand = new Random(new Random().nextLong());
            Calendar cal = Calendar.getInstance();
            List list = new ArrayList(level1);
            for (int i = 0; i < level1; i++) {
    Severity: Minor
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static class TreeModelFactory {
        public static DefaultTreeModel getSingleColDefaultTreeModel(int level1, int level2, int level3) {
            return getSingleColDefaultTreeModel(level1 ,level2, level3,"item");
        }
        public static DefaultTreeModel getSingleColDefaultTreeModel(int level1, int level2, int level3, String label) {
    Severity: Major
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java and 1 other location - About 2 days to fix
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 180..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 971.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public static class ListboxRendererFactory {
        public static ListitemRenderer getBeanItemRenderer() {
            return new ListitemRenderer() {
                public void render(Listitem item, Object data, int index) throws Exception {
                    SampleBean b = (SampleBean) data;
    Severity: Major
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java and 3 other locations - About 6 hrs to fix
    zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java on lines 272..337
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 272..337
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 339..403

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 418.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        public static class GridRendererFactory {
        public static RowRenderer getBeanRowRenderer() {
            return new RowRenderer() {
                public void render(Row row, Object data, int index) throws Exception {
                    SampleBean b = (SampleBean) data;
    Severity: Major
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java and 3 other locations - About 6 hrs to fix
    zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java on lines 339..403
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 272..337
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 339..403

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 418.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static class TreeRendererFactory {
        public static TreeitemRenderer getBeanTreeitemRenderer() {
            return new TreeitemRenderer() {
                public void render(Treeitem item, Object data, int index) throws Exception {
                    SampleBean b = (SampleBean) ((DefaultTreeNode) data).getData();
    Severity: Major
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java and 1 other location - About 6 hrs to fix
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 405..463

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 387.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static class GroupModelFactory {
        public static GroupsModelArray getBeanGroupsModelArray(int count) {
            return getBeanGroupsModelArray(count, "item");
        }
        public static GroupsModelArray getBeanGroupsModelArray(int count, String label) {
    Severity: Major
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java and 1 other location - About 4 hrs to fix
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 140..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 292.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static String[][] getMultiColumnArray(int count, int column) {
        String[][] data = new String[count][column];
        Random rand = new Random(new Random().nextLong());
        for (int i = 0; i < count; i++) {
            data[i] = new String[column];
    Severity: Major
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java and 1 other location - About 2 hrs to fix
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 76..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static class SampleBean {
        private String name;
        private int number;
        private Date date;
    Severity: Major
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java and 1 other location - About 1 hr to fix
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 465..501

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        public static List getList(int count, String label, int range) {
        List list = new ArrayList(count);
        Random rand = new Random(new Random().nextLong());
        for (int i = 0; i < count; i++) {
            list.add(label + " " + rand.nextInt(range));
    Severity: Major
    Found in zksandbox/src/main/java/org/zkoss/zksandbox/ModelProvider.java and 1 other location - About 1 hr to fix
    zktest/src/main/java/org/zkoss/zktest/util/ModelProvider.java on lines 67..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status