Sign upLogin

zkoss/zk

View on GitHub
Star
zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java

Summary

Maintainability
C
1 day
Test Coverage

F0011 has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

public class F0011 extends BindComposer {
    private Date bday1;
    private Date bday2;
    private String value1;
    private String value2;
Severity: Minor
Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            addValidator("validator5", new Validator() {
            public void validate(ValidationContext ctx) {
                BindUtils.postNotifyChange(null, null, F0011.this, "message5");
                if(!ctx.isValid()){
                    return;
    Severity: Major
    Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java and 1 other location - About 2 hrs to fix
    zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java on lines 105..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            addValidator("validator32", new Validator() {
            public void validate(ValidationContext ctx) {
                BindUtils.postNotifyChange(null, null, F0011.this, "message3");
                if(!ctx.isValid()){
                    return;
    Severity: Major
    Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java and 1 other location - About 2 hrs to fix
    zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java on lines 167..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if(sdf.format(d).compareTo(today)<=0){
                    setMessage2("date "+p.getProperty()+" must large than today");
                    ctx.setInvalid();
                    return;
                }
    Severity: Minor
    Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java and 1 other location - About 30 mins to fix
    zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java on lines 63..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if(sdf.format(d).compareTo(today)>=0){
                    setMessage1("date "+p.getProperty()+" must small than today");
                    ctx.setInvalid();
                    return;
                }
    Severity: Minor
    Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java and 1 other location - About 30 mins to fix
    zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java on lines 81..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if(v1==null || "".equals(v1.trim())){
                    setMessage3(p.getProperty()+" is empty");
                    ctx.setInvalid();
                    return;
                }
    Severity: Minor
    Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java and 1 other location - About 30 mins to fix
    zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java on lines 130..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if(val==null || "".equals(val.trim())){
                    setMessage4(p.getProperty()+" is empty");
                    ctx.setInvalid();
                    return;
                }
    Severity: Minor
    Found in zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java and 1 other location - About 30 mins to fix
    zktest/src/main/java/org/zkoss/zktest/bind/issue/F0011.java on lines 97..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status