Sign upLogin

zkoss/zk

View on GitHub
Star
zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java

Summary

Maintainability
F
3 days
Test Coverage

Method updateModelByTag has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

    public void updateModelByTag() {
        fileModel.clear();
        final String r = getDesktop().getWebApp().getRealPath("/");
        final File test2 = new File(r, PATH);
        final String pattern = ((Textbox) getFellow("w1").getFellow("fnt"))
Severity: Minor
Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MainLayout.java has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* MainLayout.java

{{IS_NOTE
    Purpose:
Severity: Minor
Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 4 hrs to fix

    Method updateModelByTag has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void updateModelByTag() {
        fileModel.clear();
        final String r = getDesktop().getWebApp().getRealPath("/");
        final File test2 = new File(r, PATH);
        final String pattern = ((Textbox) getFellow("w1").getFellow("fnt"))
    Severity: Major
    Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 2 hrs to fix

      MainLayout has 23 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class MainLayout extends Borderlayout {
    private static final Logger log = LoggerFactory.getLogger(MainLayout.class);

    ListModelList fileModel = new ListModelList();
    Map relatedFileModel = new LinkedHashMap();
      Severity: Minor
      Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 2 hrs to fix

        Method onCreate has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void onCreate() {
        try {
            ServletContext context = ServletFns.getCurrentServletContext();
            prop = new Properties();
            prop.load(new FileInputStream(new File(context.getRealPath(PATH + CONFIG))));
        Severity: Major
        Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 2 hrs to fix

          Method importFileName has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void importFileName() throws SuspendNotAllowedException, InterruptedException {
        final Window w = new Window();
        w.setTitle("Import File Name");
        w.setWidth("300px");
        w.setClosable(true);
          Severity: Major
          Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 2 hrs to fix

            Method accept has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                    public boolean accept(File dir, String name) {
            for (int i = 0; i < SKIP_LIST.length; i++)
                if (name.equals(SKIP_LIST[i]))
                    return false;
            final String n = name;
            Severity: Minor
            Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                    if (ptns[j].trim().length() > 1 && vals[k].trim().length() > 1) {
                            if (vals[k].trim().toLowerCase(java.util.Locale.ENGLISH).indexOf(ptns[j].trim().toLowerCase(java.util.Locale.ENGLISH)) > -1) {
                                m = true;
                                break;
                            }
            Severity: Major
            Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if (ptns[j].trim().length() > 1 && (vals[k].trim().length()-1 > 1)) {
                            if (vals[k].trim().toLowerCase(java.util.Locale.ENGLISH).indexOf(ptns[j].trim().toLowerCase(java.util.Locale.ENGLISH).substring(1)) > -1) {
                                m = false;
                                break;
                            }
              Severity: Major
              Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 45 mins to fix

                Avoid too many return statements within this method.
                Open

                                return n.toUpperCase().indexOf(str.toUpperCase()) >= 0;
                Severity: Major
                Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return matcher.matches();
                  Severity: Major
                  Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java - About 30 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            public MyFilenameFilter(String pattern, boolean reg) {
            if (pattern == null)
                pattern = "";
            pattern = pattern.trim();
            this.str = pattern;
                    Severity: Major
                    Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java and 1 other location - About 1 hr to fix
                    zktest/src/main/java/org/zkoss/zktest/test2/MainWindow.java on lines 156..164

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 77.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        static class FileitemRenderer implements ListitemRenderer {
        SimpleDateFormat format = new SimpleDateFormat("yyyy/MM/dd mm:ss");

        public void render(Listitem item, Object data, int index) throws Exception {
            File file = (File) data;
                    Severity: Minor
                    Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java and 1 other location - About 45 mins to fix
                    zktest/src/main/java/org/zkoss/zktest/test2/MainWindow.java on lines 190..199

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (reg) {
                Matcher matcher = pattern.matcher(n);
                return matcher.matches();
            } else {
                return n.toUpperCase().indexOf(str.toUpperCase()) >= 0;
                    Severity: Minor
                    Found in zktest/src/main/java/org/zkoss/zktest/test2/MainLayout.java and 1 other location - About 30 mins to fix
                    zktest/src/main/java/org/zkoss/zktest/test2/MainWindow.java on lines 180..185

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 42.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status