Sign upLogin

zkoss/zk

View on GitHub
Star
zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java

Summary

Maintainability
F
4 days
Test Coverage

Method fillShadowElement has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
Open

    private JSONObject fillShadowElement(HtmlShadowElement se, AbstractComponent current, ListIterator<AbstractComponent> cit) {
        String name = se.toString();
        int index = name.lastIndexOf("->");
        if (index > 0)
            name = name.substring(index + 2);
Severity: Minor
Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fillShadowHost has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    private JSONObject fillShadowHost(Component host) {
        JSONObject rootData = fillComponentOnly(host);
        JSONArray childrenArray = new JSONArray();
        rootData.put("children", childrenArray);
        List<AbstractComponent> children = host.getChildren();
Severity: Minor
Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fillShadowElement has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private JSONObject fillShadowElement(HtmlShadowElement se, AbstractComponent current, ListIterator<AbstractComponent> cit) {
        String name = se.toString();
        int index = name.lastIndexOf("->");
        if (index > 0)
            name = name.substring(index + 2);
Severity: Major
Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java - About 3 hrs to fix

    File DebuggerComposer.java has 285 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /** DebuggerComposer.java.

    Purpose:
        
    Description:
    Severity: Minor
    Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java - About 2 hrs to fix

      Method fillShadowHost has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private JSONObject fillShadowHost(Component host) {
        JSONObject rootData = fillComponentOnly(host);
        JSONArray childrenArray = new JSONArray();
        rootData.put("children", childrenArray);
        List<AbstractComponent> children = host.getChildren();
      Severity: Major
      Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java - About 2 hrs to fix

        Avoid deeply nested control flow statements.
        Open

                                    while (sit.hasNext()) {
                                childrenArray.add(fillShadowElement(sit.next()));
                            }
        Severity: Major
        Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (!cit.hasNext()) // draw the rest
                                sit.previous();
          Severity: Major
          Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                private void log1(HtmlShadowElement se, JSONObject data) {
        String name = se.toString();
        int index = name.lastIndexOf("->");
        if (index > 0)
            name = name.substring(index + 2);
            Severity: Major
            Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java and 1 other location - About 3 hrs to fix
            zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/ShadowComposer.java on lines 67..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 213.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                private void log0(HtmlShadowElement se, int depth) {
        StringBuilder sb = new StringBuilder();
        for (int i = 0; i < depth; i++)
            sb.append("\t");
        log(se.toString());
            Severity: Major
            Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java and 1 other location - About 2 hrs to fix
            zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/ShadowComposer.java on lines 87..101

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 167.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                case UNKNOWN:
                        childrenArray.add(fillShadowElement(seNext));
                        if (sit.hasNext())
                            seNext = sit.next();
                        else {
            Severity: Minor
            Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java and 1 other location - About 40 mins to fix
            zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java on lines 86..94

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                case UNKNOWN:
                        childrenArray.add(fillShadowElement(seNext));
                        if (sit.hasNext())
                            seNext = sit.next();
                        else {
            Severity: Minor
            Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java and 1 other location - About 40 mins to fix
            zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java on lines 160..168

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                switch(HtmlShadowElement.inRange(se, next)) { // in parent range
                    case IN_RANGE:
                    case FIRST:
                    case LAST:
                        childrenArray.add(fillComponent(next));
            Severity: Minor
            Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java and 1 other location - About 35 mins to fix
            zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java on lines 203..213

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            switch(HtmlShadowElement.inRange(se, next)) { // in parent range
                case IN_RANGE:
                case FIRST:
                case LAST:
                    childrenArray.add(fillComponent(next));
            Severity: Minor
            Found in zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java and 1 other location - About 35 mins to fix
            zktest/src/main/java/org/zkoss/zktest/zats/zuti/composer/DebuggerComposer.java on lines 181..191

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status