Sign upLogin

zkoss/zk

View on GitHub
Star
zul/src/main/java/org/zkoss/zul/ListModelList.java

Summary

Maintainability
D
2 days
Test Coverage

ListModelList has 49 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ListModelList<E> extends AbstractListModel<E> implements Sortable<E>, List<E>, java.io.Serializable {
    private static final long serialVersionUID = 20120206122641L;

    protected List<E> _list;
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/ListModelList.java - About 6 hrs to fix

    File ListModelList.java has 318 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* ListModelList.java

{{IS_NOTE
    Purpose:
    Severity: Minor
    Found in zul/src/main/java/org/zkoss/zul/ListModelList.java - About 3 hrs to fix

      Method removePartial has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          private boolean removePartial(Collection<?> c, boolean exclude) {
        boolean removed = false;
        int index = 0;
        int begin = -1;
        // B60-ZK-1126.zul
      Severity: Minor
      Found in zul/src/main/java/org/zkoss/zul/ListModelList.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method listIterator has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public ListIterator<E> listIterator(final int index) {
        return new ListIterator<E>() {
            private ListIterator<E> _it = _list.listIterator(index);
            private E _current = null;
      Severity: Minor
      Found in zul/src/main/java/org/zkoss/zul/ListModelList.java - About 1 hr to fix

        Method removePartial has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private boolean removePartial(Collection<?> c, boolean exclude) {
        boolean removed = false;
        int index = 0;
        int begin = -1;
        // B60-ZK-1126.zul
        Severity: Minor
        Found in zul/src/main/java/org/zkoss/zul/ListModelList.java - About 1 hr to fix

          Method listIterator has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public ListIterator<E> listIterator(final int index) {
        return new ListIterator<E>() {
            private ListIterator<E> _it = _list.listIterator(index);
            private E _current = null;
          Severity: Minor
          Found in zul/src/main/java/org/zkoss/zul/ListModelList.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method removeRange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public void removeRange(int fromIndex, int toIndex) {
        if (fromIndex > toIndex) {
            throw new UiException(
                    "fromIndex must less than toIndex: fromIndex: " + fromIndex + ", toIndex: " + toIndex);
        }
          Severity: Minor
          Found in zul/src/main/java/org/zkoss/zul/ListModelList.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 5 locations. Consider refactoring.
          Open

              public void clear() {
        int i2 = _list.size() - 1;
        if (i2 < 0) {
            return;
        }
          Severity: Major
          Found in zul/src/main/java/org/zkoss/zul/ListModelList.java and 4 other locations - About 40 mins to fix
          zul/src/main/java/org/zkoss/zul/ListModelMap.java on lines 218..226
          zul/src/main/java/org/zkoss/zul/ListModelMap.java on lines 536..544
          zul/src/main/java/org/zkoss/zul/ListModelMap.java on lines 742..750
          zul/src/main/java/org/zkoss/zul/ListModelSet.java on lines 216..224

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public ListModelList(E[] array) {
        _list = new ArrayList<E>(array.length);
        for (int j = 0; j < array.length; ++j)
            _list.add(array[j]);
    }
          Severity: Minor
          Found in zul/src/main/java/org/zkoss/zul/ListModelList.java and 1 other location - About 40 mins to fix
          zul/src/main/java/org/zkoss/zul/ListModelSet.java on lines 97..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status