Sign upLogin

zkoss/zk

View on GitHub
Star
zul/src/main/java/org/zkoss/zul/Panel.java

Summary

Maintainability
F
5 days
Test Coverage

Panel has 49 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Panel extends XulElement implements Framable {
    private Toolbar _tbar, _bbar, _fbar;
    private Panelchildren _panelchildren;
    private Caption _caption;
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 6 hrs to fix

    Method beforeChildAdded has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

        public void beforeChildAdded(Component newChild, Component refChild) {
        if (newChild instanceof Caption) {
            if (_caption != null && _caption != newChild)
                throw new UiException("Only one caption is allowed: " + this);
        } else if (refChild instanceof Caption) {
    Severity: Minor
    Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Panel.java has 396 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* Panel.java

    Purpose:

    Description:
    Severity: Minor
    Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 5 hrs to fix

      Method insertBefore has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean insertBefore(Component newChild, Component refChild) {
        if (newChild instanceof Caption) {
            refChild = getFirstChild();
            //always makes caption as the first child
            if (super.insertBefore(newChild, refChild)) {
      Severity: Minor
      Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method addToolbar has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean addToolbar(String name, Toolbar toolbar) {
        Component refChild = null;
        if ("tbar".equals(name)) {
            if (_tbar != null)
                throw new UiException("Only one top toolbar child is allowed: " + this);
      Severity: Minor
      Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method insertBefore has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public boolean insertBefore(Component newChild, Component refChild) {
        if (newChild instanceof Caption) {
            refChild = getFirstChild();
            //always makes caption as the first child
            if (super.insertBefore(newChild, refChild)) {
      Severity: Minor
      Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 1 hr to fix

        Method addToolbar has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public boolean addToolbar(String name, Toolbar toolbar) {
        Component refChild = null;
        if ("tbar".equals(name)) {
            if (_tbar != null)
                throw new UiException("Only one top toolbar child is allowed: " + this);
        Severity: Minor
        Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 1 hr to fix

          Method service has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void service(org.zkoss.zk.au.AuRequest request, boolean everError) {
        final String cmd = request.getCommand();
        if (cmd.equals(Events.ON_OPEN)) {
            OpenEvent evt = OpenEvent.getOpenEvent(request);
            _open = evt.isOpen();
          Severity: Minor
          Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 1 hr to fix

            Method beforeChildAdded has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void beforeChildAdded(Component newChild, Component refChild) {
        if (newChild instanceof Caption) {
            if (_caption != null && _caption != newChild)
                throw new UiException("Only one caption is allowed: " + this);
        } else if (refChild instanceof Caption) {
            Severity: Minor
            Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 1 hr to fix

              Method service has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void service(org.zkoss.zk.au.AuRequest request, boolean everError) {
        final String cmd = request.getCommand();
        if (cmd.equals(Events.ON_OPEN)) {
            OpenEvent evt = OpenEvent.getOpenEvent(request);
            _open = evt.isOpen();
              Severity: Minor
              Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method renderProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected void renderProperties(org.zkoss.zk.ui.sys.ContentRenderer renderer) throws java.io.IOException {
        super.renderProperties(renderer);

        if (_title.length() > 0)
            render(renderer, "title", _title);
              Severity: Minor
              Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return false;
              Severity: Major
              Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 30 mins to fix

                Method onChildRemoved has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public void onChildRemoved(Component child) {
        super.onChildRemoved(child);
        if (_caption == child)
            _caption = null;
        else if (_tbar == child)
                Severity: Minor
                Found in zul/src/main/java/org/zkoss/zul/Panel.java - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    static {
        addClientEvent(Panel.class, Events.ON_CLOSE, 0);
        addClientEvent(Panel.class, Events.ON_MOVE, CE_DUPLICATE_IGNORE | CE_IMPORTANT);
        addClientEvent(Panel.class, Events.ON_SIZE, CE_DUPLICATE_IGNORE | CE_IMPORTANT);
        addClientEvent(Panel.class, Events.ON_OPEN, CE_IMPORTANT);
                Severity: Major
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 1 other location - About 1 hr to fix
                zul/src/main/java/org/zkoss/zul/Window.java on lines 146..154

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 108.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public void onChildRemoved(Component child) {
        super.onChildRemoved(child);
        if (_caption == child)
            _caption = null;
        else if (_tbar == child)
                Severity: Major
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 1 other location - About 1 hr to fix
                zul/src/main/java/org/zkoss/zul/Borderlayout.java on lines 241..253

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        } else if (cmd.equals(Events.ON_MAXIMIZE)) {
            MaximizeEvent evt = MaximizeEvent.getMaximizeEvent(request);
            setLeftDirectly(evt.getLeft());
            setTopDirectly(evt.getTop());
            setWidthDirectly(evt.getWidth());
                Severity: Major
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 2 other locations - About 1 hr to fix
                zul/src/main/java/org/zkoss/zul/Panel.java on lines 691..701
                zul/src/main/java/org/zkoss/zul/Window.java on lines 1016..1026

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 74.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        } else if (cmd.equals(Events.ON_MINIMIZE)) {
            MinimizeEvent evt = MinimizeEvent.getMinimizeEvent(request);
            setLeftDirectly(evt.getLeft());
            setTopDirectly(evt.getTop());
            setWidthDirectly(evt.getWidth());
                Severity: Major
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 2 other locations - About 1 hr to fix
                zul/src/main/java/org/zkoss/zul/Panel.java on lines 681..691
                zul/src/main/java/org/zkoss/zul/Window.java on lines 1016..1026

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 74.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public void setMinimized(boolean minimized) {
        if (_minimized != minimized) {
            if (!_minimizable)
                throw new UiException("not minimizable, " + this);
                Severity: Major
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 1 other location - About 1 hr to fix
                zul/src/main/java/org/zkoss/zul/Window.java on lines 248..261

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 72.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public void setMaximized(boolean maximized) {
        if (_maximized != maximized) {
            if (!_maximizable)
                throw new UiException("Not maximizable, " + this);
                Severity: Minor
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 1 other location - About 55 mins to fix
                zul/src/main/java/org/zkoss/zul/Window.java on lines 192..204

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 8 locations. Consider refactoring.
                Open

                    public void setTitle(String title) {
        if (title == null)
            title = "";
        if (!Objects.equals(_title, title)) {
            _title = title;
                Severity: Major
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 7 other locations - About 40 mins to fix
                zul/src/main/java/org/zkoss/zul/Anchorchildren.java on lines 68..75
                zul/src/main/java/org/zkoss/zul/Checkbox.java on lines 125..132
                zul/src/main/java/org/zkoss/zul/Groupbox.java on lines 168..175
                zul/src/main/java/org/zkoss/zul/Hlayout.java on lines 41..48
                zul/src/main/java/org/zkoss/zul/Menu.java on lines 102..109
                zul/src/main/java/org/zkoss/zul/Window.java on lines 392..399
                zul/src/main/java/org/zkoss/zul/impl/LabelElement.java on lines 46..53

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (border == null || "0".equals(border) || "false".equals(border))
            border = "none";
        else if ("true".equals(border))
            border = "normal";
                Severity: Minor
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 1 other location - About 40 mins to fix
                zul/src/main/java/org/zkoss/zul/Window.java on lines 360..363

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 7 locations. Consider refactoring.
                Open

                    public void setMinheight(int minheight) {
        if (minheight < 0)
            minheight = 100;
        if (_minheight != minheight) {
            _minheight = minheight;
                Severity: Major
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 6 other locations - About 35 mins to fix
                zul/src/main/java/org/zkoss/zul/Listbox.java on lines 789..796
                zul/src/main/java/org/zkoss/zul/Listheader.java on lines 368..375
                zul/src/main/java/org/zkoss/zul/Panel.java on lines 341..348
                zul/src/main/java/org/zkoss/zul/Treecol.java on lines 322..329
                zul/src/main/java/org/zkoss/zul/Window.java on lines 298..305
                zul/src/main/java/org/zkoss/zul/Window.java on lines 322..329

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 7 locations. Consider refactoring.
                Open

                    public void setMinwidth(int minwidth) {
        if (minwidth < 0)
            minwidth = 200;
        if (_minwidth != minwidth) {
            _minwidth = minwidth;
                Severity: Major
                Found in zul/src/main/java/org/zkoss/zul/Panel.java and 6 other locations - About 35 mins to fix
                zul/src/main/java/org/zkoss/zul/Listbox.java on lines 789..796
                zul/src/main/java/org/zkoss/zul/Listheader.java on lines 368..375
                zul/src/main/java/org/zkoss/zul/Panel.java on lines 317..324
                zul/src/main/java/org/zkoss/zul/Treecol.java on lines 322..329
                zul/src/main/java/org/zkoss/zul/Window.java on lines 298..305
                zul/src/main/java/org/zkoss/zul/Window.java on lines 322..329

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status