Sign upLogin

zkoss/zk

View on GitHub
Star
zul/src/main/java/org/zkoss/zul/impl/GroupsListModel.java

Summary

Maintainability
D
1 day
Test Coverage

GroupsListModel has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

public class GroupsListModel<D, G, F> extends AbstractListModel<Object> implements GroupsSelectableModel<Object> {
    protected GroupsModel<D, G, F> _model;
    private transient int _size;
    /** An array of the group offset.
     * The group offset is the offset from 0 that a group shall appear
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/impl/GroupsListModel.java - About 4 hrs to fix

    Method onChange has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

            public void onChange(GroupsDataEvent event) {
            int type = event.getType(), j0 = event.getIndex0(), j1 = event.getIndex1();

            switch (type) {
            case GroupsDataEvent.CONTENTS_CHANGED:
    Severity: Minor
    Found in zul/src/main/java/org/zkoss/zul/impl/GroupsListModel.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File GroupsListModel.java has 308 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* GroupsListModelImpl.java

    Purpose:
        
    Description:
    Severity: Minor
    Found in zul/src/main/java/org/zkoss/zul/impl/GroupsListModel.java - About 3 hrs to fix

      Method onChange has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public void onChange(GroupsDataEvent event) {
            int type = event.getType(), j0 = event.getIndex0(), j1 = event.getIndex1();

            switch (type) {
            case GroupsDataEvent.CONTENTS_CHANGED:
      Severity: Major
      Found in zul/src/main/java/org/zkoss/zul/impl/GroupsListModel.java - About 2 hrs to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                private GroupDataInfo(byte type, int groupIndex, int offset, boolean open) {
            _type = type;
            _groupIndex = groupIndex;
            _offset = offset;
            _open = open;
        Severity: Major
        Found in zul/src/main/java/org/zkoss/zul/impl/GroupsListModel.java and 3 other locations - About 30 mins to fix
        zk/src/main/java/org/zkoss/zk/ui/impl/Initiators.java on lines 100..105
        zktest/src/main/java/org/zkoss/zktest/bind/issue/B01698TreePerformance.java on lines 67..72
        zweb/src/main/java/org/zkoss/web/servlet/dsp/impl/ActionContextImpl.java on lines 38..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status