Sign upLogin

zkoss/zk

View on GitHub
Star
zul/src/main/java/org/zkoss/zul/impl/Utils.java

Summary

Maintainability
D
2 days
Test Coverage

Method outLocaleJavaScript has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static final String outLocaleJavaScript() {
        final StringBuffer sb = new StringBuffer(1024).append("zk.$default(msgzul, {");

        addLocaleJS(sb, "VALUE_NOT_MATCHED", MZul.VALUE_NOT_MATCHED);
        addLocaleJS(sb, "EMPTY_NOT_ALLOWED", MZul.EMPTY_NOT_ALLOWED);
Severity: Major
Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java - About 3 hrs to fix

    File Utils.java has 285 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* Utils.java

    Purpose:
        
    Description:
    Severity: Minor
    Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java - About 2 hrs to fix

      Method stringToInts has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public static final int[] stringToInts(String numbers, int defaultValue) throws WrongValueException {
        if (numbers == null)
            return null;

        List<Integer> list = new LinkedList<Integer>();
      Severity: Minor
      Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getDynamicMediaURI has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public static String getDynamicMediaURI(AbstractComponent comp, int version, String name, String format) {
        final Desktop desktop = comp.getDesktop();
        if (desktop == null)
            return ""; //no avail at client
      Severity: Minor
      Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method stringToInts has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static final int[] stringToInts(String numbers, int defaultValue) throws WrongValueException {
        if (numbers == null)
            return null;

        List<Integer> list = new LinkedList<Integer>();
      Severity: Minor
      Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java - About 1 hr to fix

        Method stringToArray has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public static final String[] stringToArray(String src, String defaultValue) {
        if (src == null)
            return null;

        List<String> list = new LinkedList<String>();
        Severity: Minor
        Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getComponentById has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static Component getComponentById(Component comp, String id) {
        final int len = id.length();
        if (id.startsWith("uuid(") && id.charAt(len - 1) == ')') {
            Desktop dt = comp.getDesktop();
            if (dt == null) {
        Severity: Minor
        Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method arrayToString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static final String arrayToString(Object[] ary) {
        if (ary == null || ary.length == 0)
            return "";

        final StringBuffer sb = new StringBuffer(50);
        Severity: Minor
        Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for (int j = 0; j < ary.length; ++j) {
            if (j > 0)
                sb.append(',');
            sb.append(ary[j]);
        }
        Severity: Minor
        Found in zul/src/main/java/org/zkoss/zul/impl/Utils.java and 1 other location - About 40 mins to fix
        zk/src/main/java/org/zkoss/zk/ui/select/impl/ComponentMatchCtx.java on lines 207..211

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status