Sign upLogin

zkoss/zk

View on GitHub
Star
zweb/src/main/java/org/zkoss/web/portlet/PortletHttpSession.java

Summary

Maintainability
A
2 hrs
Test Coverage

PortletHttpSession has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

public class PortletHttpSession implements HttpSession {
    private final PortletSession _sess;

    public static HttpSession getInstance(PortletSession sess) {
        if (sess instanceof HttpSession)
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/portlet/PortletHttpSession.java - About 2 hrs to fix

    Method equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public boolean equals(Object o) {
        if (this == o)
            return true;
        PortletSession val = o instanceof PortletSession ? (PortletSession) o
                : o instanceof PortletHttpSession ? ((PortletHttpSession) o)._sess : null;
    Severity: Minor
    Found in zweb/src/main/java/org/zkoss/web/portlet/PortletHttpSession.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status