Sign upLogin

zkoss/zk

View on GitHub
Star
zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java

Summary

Maintainability
D
2 days
Test Coverage

Method encodeURL0 has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

    private static final String encodeURL0(ServletContext ctx, ServletRequest request, ServletResponse response,
            String uri) throws Exception {
        if (uri == null || uri.length() == 0)
            return uri; //keep as it is
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Encodes.java has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* Encodes.java

    Purpose:
        
    Description:
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 2 hrs to fix

    Method encodeURL0 has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static final String encodeURL0(ServletContext ctx, ServletRequest request, ServletResponse response,
            String uri) throws Exception {
        if (uri == null || uri.length() == 0)
            return uri; //keep as it is
    Severity: Major
    Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 2 hrs to fix

      Method removeFromQueryString has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public static final StringBuffer removeFromQueryString(StringBuffer sb, String name)
            throws UnsupportedEncodingException {
        name = encodeURIComponent(name);

        if (name == null || name.isEmpty())
      Severity: Minor
      Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method encodeURI0 has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private static final String encodeURI0(String s, char[] unsafes) throws UnsupportedEncodingException {
        if (s == null)
            return null;

        final String charset = Charsets.getURICharset();
      Severity: Minor
      Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method removeFromQueryString has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static final StringBuffer removeFromQueryString(StringBuffer sb, String name)
            throws UnsupportedEncodingException {
        name = encodeURIComponent(name);

        if (name == null || name.isEmpty())
      Severity: Minor
      Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 1 hr to fix

        Method addToQueryString has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static final StringBuffer addToQueryString(StringBuffer sb, String name, Object value)
            throws UnsupportedEncodingException {
        if (value instanceof Object[]) {
            final Object[] vals = (Object[]) value;
            if (vals.length == 0) {
        Severity: Minor
        Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method urlEncoder has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private static URLEncoder urlEncoder() {
        if (_urlenc == null) {
            final String cls = Library.getProperty("org.zkoss.web.servlet.http.URLEncoder");
            if (cls != null && cls.length() > 0) {
                try {
        Severity: Minor
        Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method encodeURL has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public String encodeURL(ServletContext ctx, ServletRequest request, ServletResponse response, String uri,
                URLEncoder defaultEncoder) throws Exception {
        Severity: Minor
        Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 35 mins to fix

          Method encodeURL has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  public String encodeURL(ServletContext ctx, ServletRequest request, ServletResponse response, String url,
                URLEncoder defaultEncoder) throws Exception;
          Severity: Minor
          Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static final StringBuffer setToQueryString(StringBuffer sb, Map params) throws UnsupportedEncodingException {
        if (params != null) {
            for (Iterator it = params.entrySet().iterator(); it.hasNext();) {
                final Map.Entry me = (Map.Entry) it.next();
                setToQueryString(sb, (String) me.getKey(), me.getValue());
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java and 1 other location - About 55 mins to fix
            zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java on lines 153..161

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static final StringBuffer addToQueryString(StringBuffer sb, Map params) throws UnsupportedEncodingException {
        if (params != null) {
            for (Iterator it = params.entrySet().iterator(); it.hasNext();) {
                final Map.Entry me = (Map.Entry) it.next();
                addToQueryString(sb, (String) me.getKey(), me.getValue());
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java and 1 other location - About 55 mins to fix
            zweb/src/main/java/org/zkoss/web/servlet/http/Encodes.java on lines 260..268

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status