Sign upLogin

zkoss/zk

View on GitHub
Star
zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java

Summary

Maintainability
D
2 days
Test Coverage

Method resolveVariable has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    public Object resolveVariable(String name) throws XelException {
        if ("pageContext".equals(name)) {
            return getPageContext();
        } else if ("pageScope".equals(name)) {
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

RequestXelResolver has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

public abstract class RequestXelResolver implements VariableResolver {
    private final ServletContext _ctx;
    private final ServletRequest _request;
    private final ServletResponse _response;
    private HttpSession _sess;
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 3 hrs to fix

    Method resolveVariable has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @SuppressWarnings("unchecked")
    public Object resolveVariable(String name) throws XelException {
        if ("pageContext".equals(name)) {
            return getPageContext();
        } else if ("pageScope".equals(name)) {
    Severity: Major
    Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 3 hrs to fix

      Method getValue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

                      protected Object getValue(String key) {
                    Object o = _values.get(key);
                    if (o == null) {
                        final Enumeration e = hreq.getHeaders(key);
                        if (e == null || !e.hasMoreElements())
      Severity: Minor
      Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return getRequestScope();
      Severity: Major
      Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return Collections.EMPTY_MAP;
        Severity: Major
        Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return Collections.EMPTY_MAP;
          Severity: Major
          Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return _request != null ? new ParameterMap(_request) : Collections.EMPTY_MAP;
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return getPageContext();
              Severity: Major
              Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return new AttributesMap() {
                //It is OK to cache because it is readonly
                private final Map _values = new HashMap();

                protected Enumeration getKeys() {
                Severity: Major
                Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return findAttribute(name);
                  Severity: Major
                  Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return _request != null ? _request.getParameterMap() : Collections.EMPTY_MAP;
                    Severity: Major
                    Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return getSessionScope();
                      Severity: Major
                      Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return Collections.EMPTY_MAP;
                        Severity: Major
                        Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return getApplicationScope();
                          Severity: Major
                          Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return new AttributesMap() {
                protected Enumeration getKeys() {
                    return hreq.getHeaderNames();
                }
                            Severity: Major
                            Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java - About 30 mins to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      return _sessScope = new AttributesMap() {
            @SuppressWarnings("unchecked")
            protected Enumeration<String> getKeys() {
                return sess.getAttributeNames();
            }
                              Severity: Minor
                              Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java and 1 other location - About 45 mins to fix
                              zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java on lines 276..293

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 56.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      return _appScope = new AttributesMap() {
            @SuppressWarnings("unchecked")
            protected Enumeration<String> getKeys() {
                return _ctx.getAttributeNames();
            }
                              Severity: Minor
                              Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java and 1 other location - About 45 mins to fix
                              zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java on lines 251..268

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 56.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          return new AttributesMap() {
                protected Enumeration getKeys() {
                    return _ctx.getInitParameterNames();
                }
                              Severity: Minor
                              Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java and 1 other location - About 35 mins to fix
                              zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java on lines 126..142

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 46.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          return new AttributesMap() {
                protected Enumeration getKeys() {
                    return hreq.getHeaderNames();
                }
                              Severity: Minor
                              Found in zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java and 1 other location - About 35 mins to fix
                              zweb/src/main/java/org/zkoss/web/servlet/xel/RequestXelResolver.java on lines 185..201

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 46.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status