Sign upLogin

zkoss/zk

View on GitHub
Star
zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java

Summary

Maintainability
D
1 day
Test Coverage

Method get has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    public static final <V> V get(ResourceCache<V> cache, ServletContext ctx, String path, Object extra) {
        //20050905: Tom Yeh
        //We don't need to handle the default name if user specifies only a dir
        //because it is handled by the container directly
        //And, web  developer has to specify <welcome-file> in web.xml
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static final <V> V get(ResourceCache<V> cache, ServletContext ctx, String path, Object extra) {
        //20050905: Tom Yeh
        //We don't need to handle the default name if user specifies only a dir
        //because it is handled by the container directly
        //And, web  developer has to specify <welcome-file> in web.xml
Severity: Major
Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return null;
    Severity: Major
    Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return cache.get(new ResourceInfo(path, url, extra));
      Severity: Major
      Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return null;
        Severity: Major
        Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java - About 30 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          if (j >= 0) {
                    ctxpath = "/" + path.substring(2, j);
                    path = path.substring(j);
                } else {
                    ctxpath = "/" + path.substring(2);
          Severity: Major
          Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java and 2 other locations - About 55 mins to fix
          zweb/src/main/java/org/zkoss/web/portlet/Portlets.java on lines 121..127
          zweb/src/main/java/org/zkoss/web/servlet/Servlets.java on lines 885..891

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                              } catch (Throwable ex) {
                        final IOException ioex = getIOException(ex);
                        if (ioex == null)
                            throw SystemException.Aide.wrap(ex);
                        log.warn("Unable to load " + url, ioex);
          Severity: Minor
          Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java and 2 other locations - About 35 mins to fix
          zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java on lines 125..130
          zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java on lines 141..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                          } catch (Throwable ex) {
                    final IOException ioex = getIOException(ex);
                    if (ioex == null)
                        throw SystemException.Aide.wrap(ex);
                    log.warn("Unable to load " + flnm, ioex);
          Severity: Minor
          Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java and 2 other locations - About 35 mins to fix
          zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java on lines 103..108
          zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java on lines 141..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  } catch (Throwable ex) {
            final IOException ioex = getIOException(ex);
            if (ioex == null)
                throw SystemException.Aide.wrap(ex);
            log.warn("Unable to load " + path, ioex);
          Severity: Minor
          Found in zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java and 2 other locations - About 35 mins to fix
          zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java on lines 103..108
          zweb/src/main/java/org/zkoss/web/util/resource/ResourceCaches.java on lines 125..130

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status