Sign upLogin

zkoss/zk

View on GitHub
Star
zweb/src/main/java/org/zkoss/web/util/resource/ServletContextLocator.java

Summary

Maintainability
A
1 hr
Test Coverage

Method fixName has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private String fixName(String name, boolean prefix) {
        name = name.length() > 0 && name.charAt(0) != '/'
                ? _dir != null ? _dir + name : prefix && _prefix != null ? '/' + name : name : name;
        return prefix && _prefix != null ? _prefix + name : (_externalPrefix == null ?  "" : _externalPrefix) + name;
    }
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/util/resource/ServletContextLocator.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getResource has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public URL getResource(String name) {
        String relativePath = null;
        try {
            URL url = getResource0(relativePath = fixName(name, true));
            return url == null && _prefix != null ? getResource0(relativePath = fixName(name, false)) : url;
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/util/resource/ServletContextLocator.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status