Sign upLogin

zxing-js/library

View on GitHub
Star
src/core/pdf417/detector/Detector.ts

Summary

Maintainability
D
2 days
Test Coverage
A
90%

Function findRowsWithPattern has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  private static  findRowsWithPattern( matrix: BitMatrix,
                                                    height: /*int*/ number,
                                                    width: /*int*/ number,
                                                    startRow: /*int*/ number,
                                                    startColumn: /*int*/ number,
Severity: Minor
Found in src/core/pdf417/detector/Detector.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function detect has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  private static detect( multiple: boolean,  bitMatrix: BitMatrix): Array<ResultPoint[]> {
    const barcodeCoordinates = new Array<ResultPoint[]>();
    let row = 0;
    let column = 0;
    let foundBarcodeInRow = false;
Severity: Minor
Found in src/core/pdf417/detector/Detector.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findRowsWithPattern has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private static  findRowsWithPattern( matrix: BitMatrix,
                                                    height: /*int*/ number,
                                                    width: /*int*/ number,
                                                    startRow: /*int*/ number,
                                                    startColumn: /*int*/ number,
Severity: Minor
Found in src/core/pdf417/detector/Detector.ts - About 1 hr to fix

    Function findGuardPattern has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      private static findGuardPattern( matrix: BitMatrix,
                                         column: /*int*/ number,
                                         row: /*int*/ number,
                                         width: /*int*/ number,
                                         whiteFirst: boolean,
    Severity: Minor
    Found in src/core/pdf417/detector/Detector.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function detect has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private static detect( multiple: boolean,  bitMatrix: BitMatrix): Array<ResultPoint[]> {
    const barcodeCoordinates = new Array<ResultPoint[]>();
    let row = 0;
    let column = 0;
    let foundBarcodeInRow = false;
    Severity: Minor
    Found in src/core/pdf417/detector/Detector.ts - About 1 hr to fix

      Function findGuardPattern has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private static findGuardPattern( matrix: BitMatrix,
                                         column: /*int*/ number,
                                         row: /*int*/ number,
                                         width: /*int*/ number,
                                         whiteFirst: boolean,
      Severity: Minor
      Found in src/core/pdf417/detector/Detector.ts - About 1 hr to fix

        Function patternMatchVariance has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          private static patternMatchVariance( counters: Int32Array,  pattern: Int32Array,  maxIndividualVariance: float): float {
    let numCounters = counters.length;
    let total = 0;
    let patternLength = 0;
    for (let i = 0; i < numCounters; i++) {
        Severity: Minor
        Found in src/core/pdf417/detector/Detector.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (vertices[2] != null) {
        column = <int> Math.trunc(vertices[2].getX());
        row = <int> Math.trunc(vertices[2].getY());
      } else {
        column = <int> Math.trunc(vertices[4].getX());
        Severity: Major
        Found in src/core/pdf417/detector/Detector.ts and 1 other location - About 1 hr to fix
        src/core/pdf417/detector/Detector.ts on lines 172..175

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (result[4] != null) {
      startColumn = <int> Math.trunc(result[4].getX());
      startRow = <int> Math.trunc(result[4].getY());
    }
        Severity: Major
        Found in src/core/pdf417/detector/Detector.ts and 1 other location - About 1 hr to fix
        src/core/pdf417/detector/Detector.ts on lines 137..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            for (let i = 0; i < numCounters; i++) {
      total += counters[i];
      patternLength += pattern[i];
    }
        Severity: Minor
        Found in src/core/pdf417/detector/Detector.ts and 1 other location - About 30 mins to fix
        src/core/oned/OneDReader.ts on lines 248..251

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status