3scale/porta

View on GitHub

Showing 5,267 of 5,597 total issues

CMS::Builtin::Page::ProviderAssociationExtension#find_or_create! has the variable name 'p'
Open

        find_by_system_name(system_name) || create! do |p|
Severity: Minor
Found in app/models/cms/builtin.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CMS::Page#is_searchable? has the variable name 'i'
Open

      nodelist.none?{ |i| i.is_a?(Liquid::Tag) and not i.is_a?(Liquid::Include) }
Severity: Minor
Found in app/models/cms/page.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

HyperMegaProfiler#puts_diff has the variable name 'k'
Open

    new.each_pair do |k,v|
Severity: Minor
Found in script/hyper_mega_profiler.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CMS::Section#destroy has the variable name 's'
Open

        children.each{|s| s.parent = parent; s.save!}
Severity: Minor
Found in app/models/cms/section.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Invoice#next_transition_from_state has the variable name 't'
Open

    state_transitions.find {|t| t.to == state.to_s }
Severity: Minor
Found in app/models/invoice.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Account::CreditCard#wipe_buyers_cc_details! has the variable name 'b'
Open

    buyers.select{ |b| b.credit_card_stored? }.each do |buyer|
Severity: Minor
Found in app/models/account/credit_card.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

AuthenticationProvider::Auth0 has the name 'Auth0'
Open

class AuthenticationProvider::Auth0 < AuthenticationProvider

An Uncommunicative Module Name is a module name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CMS::Section#add_remove_by_ids has the variable name 'k'
Open

    to_add = inside_ids - to_keep.map{ |k| k.id.to_s}
Severity: Minor
Found in app/models/cms/section.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Account#fetch_dispatch_rule has the variable name 'm'
Open

    MailDispatchRule.fetch_with_retry!(system_operation: operation, account: self) do |m|
Severity: Minor
Found in app/models/account.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Cinstance#to_xml has the variable name 'k'
Open

            keys.each do |k|
Severity: Minor
Found in app/models/cinstance.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

NotificationPreferences#enabled_notifications has the variable name 'v'
Open

    enabled_preferences = preferences.select { |_, v| v }.keys
Severity: Minor
Found in app/models/notification_preferences.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CMS::Section#add_remove_by_ids has the variable name 'p'
Open

    to_keep, to_delete = inside.partition { |p| inside_ids.include?(p.id.to_s) }
Severity: Minor
Found in app/models/cms/section.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Finance::BillingStrategy::Results#skipped has the variable name 'v'
Open

    @providers.select { |k,v| v[:skip] }

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CMS::Section#dirty? has the variable name 'p'
Open

      self.pages.any? { |p| p.dirty? } ||
      self.builtins.any? { |p| p.dirty? }
Severity: Minor
Found in app/models/cms/section.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SSOToken#sso_url! has the variable name 'v'
Open

    }.delete_if{|k,v| v.nil?}
Severity: Minor
Found in app/models/sso_token.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

AccountHelper#time_zone_select_for_account has the variable name 't'
Open

                :collection => Account::ALLOWED_TIMEZONES.map { |t| [t.to_s, t.name] },
Severity: Minor
Found in app/helpers/account_helper.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

CMS::Section#add_remove_by_ids has the variable name 'a'
Open

    to_delete.each{|a| a.section = provider.sections.root; a.save} unless self.root?
Severity: Minor
Found in app/models/cms/section.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Policy#humanName has the name 'humanName'
Open

  def humanName
Severity: Minor
Found in app/models/policy.rb by reek

An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SSOToken#assign_attributes has the variable name 'k'
Open

    sanitize_for_mass_assignment(values, nil).each do |k, v|
Severity: Minor
Found in app/models/sso_token.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Finance::BillingStrategy#self.daily has the variable name 'e'
Open

      rescue => e
Severity: Minor
Found in app/models/finance/billing_strategy.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Severity
Category
Status
Source
Language