Sign upLogin

3scale/porta

View on GitHub
Star

Showing 5,267 of 5,597 total issues

SSOToken#assign_attributes has the variable name 'v'
Open

    sanitize_for_mass_assignment(values, nil).each do |k, v|
Severity: Minor
Found in app/models/sso_token.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

WebHookFailures#all has the variable name 'e'
Open

    _all.map { |e| WebHook::Failure.parse(e) }
Severity: Minor
Found in app/models/web_hook_failures.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

UsageLimitViolationsQuery::UsageLimitViolation#account has the variable name 'a'
Open

      ::Account.new { |a| a.assign_attributes(account_attributes, without_protection: true) }
Severity: Minor
Found in app/queries/usage_limit_violations_query.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ForumsHelper#voice_count has the variable name 't'
Open

    pluralize current_site.topics.to_a.sum { |t| t.voice_count }, 'voice'
Severity: Minor
Found in app/helpers/forums_helper.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

JsonHelper#json_escape has the parameter name 's'
Open

  def json_escape(s)
Severity: Minor
Found in app/helpers/json_helper.rb by reek

An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SSOToken#sso_url! has the variable name 'k'
Open

    }.delete_if{|k,v| v.nil?}
Severity: Minor
Found in app/models/sso_token.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ApplicationHelper#next_page has the variable name 'v'
Open

      "<p style='float:right;'>" + link_to("Next page"[], { :page => collection.current_page.next }.merge(params.reject{|k,v| k=="page"})) + "</p>"
Severity: Minor
Found in app/helpers/application_helper.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Buyer::PlansHelper#select_box_of_all_plans has the variable name 'p'
Open

    plans = owned_plan.issuer.published_application_plans.select{|p| p.id != owned_plan.id}
    plans << owned_plan
    plans.collect!{|p| [p.name, p.id.to_s]}
Severity: Minor
Found in app/helpers/buyer/plans_helper.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Finance::BillingStrategy::Results#with_errors has the variable name 'k'
Open

    @providers.select { |k,v| v[:errors].present? }
Severity: Minor
Found in app/models/finance/billing_strategy/results.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Finance::BillingStrategy::Results#with_errors has the variable name 'v'
Open

    @providers.select { |k,v| v[:errors].present? }
Severity: Minor
Found in app/models/finance/billing_strategy/results.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ApplicationHelper#chop has the parameter name 'l'
Open

  def chop(name, l = 15)
Severity: Minor
Found in app/helpers/application_helper.rb by reek

An Uncommunicative Parameter Name is a parameter name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Buyer::PlansHelper#plans_as_collection_for has the variable name 'p'
Open

      provider.published_application_plans.collect{|p| [p.name, p.id.to_s]}
Severity: Minor
Found in app/helpers/buyer/plans_helper.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::ServicesHelper#render_methods_pages has the variable name 'i'
Open

    methods.each_slice(page_size).with_index do |page,i|
Severity: Minor
Found in app/helpers/stats/services_helper.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Finance::BillingStrategy::Results#skipped has the variable name 'k'
Open

    @providers.select { |k,v| v[:skip] }
Severity: Minor
Found in app/models/finance/billing_strategy/results.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Plan#can_be_destroyed? has the variable name 'c'
Open

    elsif customizations.any? { |c| c.contracts.exists? }
Severity: Minor
Found in app/models/plan.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

SSOToken has the variable name 'o'
Open

  validate :account_is_provider_and_user_of_provider, :if => Proc.new {|o| o.account && o.user_id || o.username }
Severity: Minor
Found in app/models/sso_token.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Buyers::FieldsDefinitionsHelper#fields_definitions_rows has the variable name 'f'
Open

    object.defined_fields.reject{ |f| excluded_fields.include? f.name }.each do |field|
Severity: Minor
Found in app/helpers/buyers/fields_definitions_helper.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ApplicationHelper#next_page has the variable name 'k'
Open

      "<p style='float:right;'>" + link_to("Next page"[], { :page => collection.current_page.next }.merge(params.reject{|k,v| k=="page"})) + "</p>"
Severity: Minor
Found in app/helpers/application_helper.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

WebHook#ping has the variable name 'e'
Open

  rescue => e
Severity: Minor
Found in app/models/web_hook.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

UsersHelper#link_to_login_with_IP has the name 'link_to_login_with_IP'
Open

  def link_to_login_with_IP content_text=nil, options={}
Severity: Minor
Found in app/helpers/users_helper.rb by reek

An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Severity
Category
Status
Source
Language