Sign upLogin

3scale/porta

View on GitHub
Star

Showing 5,267 of 5,597 total issues

UsersHelper#link_to_login_with_IP has the name 'link_to_login_with_IP'
Open

  def link_to_login_with_IP content_text=nil, options={}
Severity: Minor
Found in app/helpers/users_helper.rb by reek

An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Finance::Api::InvoicesController has the variable name 'k'
Open

  STATES = Hash.new {|_, k| k}.merge('cancel' => 'cancelled').freeze
Severity: Minor
Found in app/controllers/finance/api/invoices_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ApplicationController#status has the variable name 'e'
Open

    rescue ::Redis::BaseError => e
Severity: Minor
Found in app/controllers/application_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Admin::FieldsDefinitionsController#new has the variable name 'f'
Open

      current_account.fields_definitions.by_target(target).map{ |f|f.name }
Severity: Minor
Found in app/controllers/admin/fields_definitions_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Admin::Api::CreditCardsController#update has the variable name 'e'
Open

      rescue  ArgumentError => e
        failed = "credit_card_expiration_month"
        @buyer.errors.add(:credit_card_expires_on)
      end
Severity: Minor
Found in app/controllers/admin/api/credit_cards_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Provider::Admin::Account::PaymentGateways::BraintreeBlueController#hack_errors has the variable name 'v'
Open

    current_account.billing_address.errors.messages.each do |k,v|
Severity: Minor
Found in app/controllers/provider/admin/account/payment_gateways/braintree_blue_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Provider::Admin::Account::PaymentGateways::BraintreeBlueController#hack_errors has the variable name 'k'
Open

    current_account.billing_address.errors.messages.each do |k,v|
Severity: Minor
Found in app/controllers/provider/admin/account/payment_gateways/braintree_blue_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Data::BaseController#render_usage has the variable name 'e'
Open

  rescue Stats::InvalidParameterError => e
Severity: Minor
Found in app/controllers/stats/data/base_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Provider::DomainsController#recover has the variable name 'p'
Open

    domains = site_account.managed_users.where(email: email_param).map{|p| p.account.external_admin_domain}.uniq
Severity: Minor
Found in app/controllers/provider/domains_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Api::BaseController#render_usage has the variable name 'e'
Open

  rescue Stats::InvalidParameterError => e
Severity: Minor
Found in app/controllers/stats/api/base_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Dashboard::MessagesPresenter#t has the name 't'
Open

  def t(key)
Severity: Minor
Found in app/presenters/dashboard/messages_presenter.rb by reek

An Uncommunicative Method Name is a method name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

NotificationPreferencesForm#notification_categories has the variable name 'c'
Open

      category      = ui_notification_categories.find { |c| c.title_key == ui_title_key }
Severity: Minor
Found in app/forms/notification_preferences_form.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Api::ServicesController#top_applications has the variable name 'e'
Open

    rescue Stats::InvalidParameterError => e
Severity: Minor
Found in app/controllers/stats/api/services_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Stats::Data::ServicesController#top_applications has the variable name 'e'
Open

    rescue Stats::InvalidParameterError => e
Severity: Minor
Found in app/controllers/stats/data/services_controller.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ActionLimiter#perform has the variable name 'e'
Open

  rescue Redis::BaseError => e
Severity: Minor
Found in app/services/action_limiter.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Backend::ModelExtensions::Metric#self.included has the variable name 'm'
Open

          after_commit :sync_backend, if: ->(m) { (m.persisted? || m.destroyed?) && !m.changed? }
Severity: Minor
Found in app/lib/backend/model_extensions/metric.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TrafficService#last_traffic_date has the variable name 'i'
Open

    days_ago = usage.reverse.find_index{|i| i > 0 }
Severity: Minor
Found in app/services/traffic_service.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

AccessControl#self.included has the variable name 'e'
Open

    base.rescue_from CanCan::AccessDenied do |e|
Severity: Minor
Found in app/lib/access_control.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Provider::Admin::AuthenticationProvidersIndexPresenter#authentication_provider_kinds has the variable name 'a'
Open

    indexed.values.flatten.sort_by { |a| a.to_param.to_s }.reverse
Severity: Minor
Found in app/presenters/provider/admin/authentication_providers_index_presenter.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

ExternalRssFeedPortlet#posts has the variable name 'p'
Open

      Nokogiri::XML(doc).xpath('//item').map do |p|
Severity: Minor
Found in app/portlets/external_rss_feed_portlet.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Severity
Category
Status
Source
Language