AndyObtiva/glimmer-dsl-swt

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            @drawable_on_mouse_move ||= drawable.handle_observation_request('on_mouse_move') do |event|
              if Shape.dragging && Shape.dragged_shape.equal?(self)
                Shape.dragged_shape.move_by((event.x - Shape.dragging_x), (event.y - Shape.dragging_y))
                Shape.dragging_x = event.x
                Shape.dragging_y = event.y

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        def max_height
          max_height_dependencies = [parent.is_a?(Drawable) && parent.size.y, !parent.is_a?(Drawable) && parent.calculated_height]
          if max_height_dependencies != @max_height_dependencies
            # do not repeat calculations
            parent_size_y, parent_calculated_height = @max_height_dependencies = max_height_dependencies

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            @drawable_on_mouse_move ||= drawable.handle_observation_request('on_mouse_move') do |event|
              if Shape.dragging && Shape.dragged_shape.equal?(self)
                Shape.dragged_shape.move_by((event.x - Shape.dragging_x), (event.y - Shape.dragging_y))
                Shape.dragging_x = event.x
                Shape.dragging_y = event.y

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        def max_width
          max_width_dependencies = [parent.is_a?(Drawable) && parent.size.x, !parent.is_a?(Drawable) && parent.calculated_width]
          if max_width_dependencies != @max_width_dependencies
            # do not repeat calculations
            parent_size_x, parent_calculated_width = @max_width_dependencies = max_width_dependencies

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

          if (@name != 'text' && @name != 'string' && has_some_background? && !has_some_foreground?) || (@name == 'path' && has_some_background?)
            @options[:fill] = true
          elsif !has_some_background? && has_some_foreground?
            @options[:fill] = false
          elsif @name == 'rectangle' && has_some_background? && has_some_foreground?

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        def x_end
          x_end_dependencies = [calculated_width, default_x?, !default_x? && x]
          if x_end_dependencies != @x_end_dependencies
            # avoid recalculation of dependencies
            calculated_width, is_default_x, x = @x_end_dependencies = x_end_dependencies

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      minimum_size BOARD_DIAMETER + AREA_MARGIN + PIECES_AREA_WIDTH + SHELL_MARGIN*2 + (OS.linux? ? 52 : (OS.windows? ? 16 : 0)), BOARD_DIAMETER + 24 + SHELL_MARGIN*2 + (OS.linux? ? 96 : (OS.windows? ? 32 : 0))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          def x
            x_dependencies = [bounds.x, parent.is_a?(Shape) && parent.absolute_x]
            if x_dependencies != @x_dependencies
              # avoid recalculating values
              bounds_x, parent_absolute_x = @x_dependencies = x_dependencies

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          def y
            y_dependencies = [bounds.y, parent.is_a?(Shape) && parent.absolute_y]
            if y_dependencies != @y_dependencies
              # avoid recalculating values
              bounds_y, parent_absolute_y = @y_dependencies = y_dependencies

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        def y_end
          y_end_dependencies = [calculated_height, default_y?, !default_y? && y]
          if y_end_dependencies != @y_end_dependencies
            # avoid recalculation of dependencies
            calculated_height, is_default_y, y = @y_end_dependencies = y_end_dependencies

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      maximum_size BOARD_DIAMETER + AREA_MARGIN + PIECES_AREA_WIDTH + SHELL_MARGIN*2 + (OS.linux? ? 52 : (OS.windows? ? 16 : 0)), BOARD_DIAMETER + 24 + SHELL_MARGIN*2 + (OS.linux? ? 96 : (OS.windows? ? 32 : 0))

• Read up
  Read up

Method update_table_item_properties_from_model has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

      def update_table_item_properties_from_model(table_item, row_index, column_index, model, model_attribute)

Method stick_figure has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  def stick_figure(x, y, width, height, &block)

Similar blocks of code found in 9 locations. Consider refactoring.

Open

            @quad_oval1 = oval {
              x          <= [@quad, :x1_value, on_read: ->(val) {val - 5}]
              y          <= [@quad, :y1_value, on_read: ->(val) {val - 5}]
              width 10
              height 10

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Open

            @cubic_oval1 = oval {
              x          <= [@cubic, :x1_value, on_read: ->(val) {val - 5}]
              y          <= [@cubic, :y1_value, on_read: ->(val) {val - 5}]
              width 10
              height 10

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Open

            @quad_oval2 = oval {
              x          <= [@quad, :cx_value, on_read: ->(val) {val - 5}]
              y          <= [@quad, :cy_value, on_read: ->(val) {val - 5}]
              width 10
              height 10

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Open

            @cubic_oval3 = oval {
              x          <= [@cubic, :cx2_value, on_read: ->(val) {val - 5}]
              y          <= [@cubic, :cy2_value, on_read: ->(val) {val - 5}]
              width 10
              height 10

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        def interpret(parent, keyword, *args, &block)
          options = args.last.is_a?(Hash) ? args.pop : {}
          UI::CustomWidget.for(keyword).new(parent, *args, options, &block).tap do |new_custom_widget|
            new_custom_widget.body_root.paint_pixel_by_pixel(&block) if block&.parameters&.count == 2

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        def default_width?
          return false unless current_parameter_name?(:width)
          width = self.width
          (width.nil? || width == :default || width == 'default' || (width.is_a?(Array) && (width.first.to_s == :default || width.first.to_s == 'default')))

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Open

            @quad_oval3 = oval {
              x          <= [@quad, :x2_value, on_read: ->(val) {val - 5}]
              y          <= [@quad, :y2_value, on_read: ->(val) {val - 5}]
              width 10
              height 10

• Read up
  Read up