Sign upLogin

AppStateESS/homestead

View on GitHub
Star

Showing 1,397 of 1,397 total issues

Function execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute()
    {
        $term = $this->term;

        $db = PdoFactory::getPdoInstance();
Severity: Minor
Found in class/Report/InternationalReservedBeds/InternationalReservedBeds.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function can_live_together has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function can_live_together()
    {
        $requestor = strToLower($this->requestor);
        $requestee = strToLower($this->requestee);
        $term = $this->term;
Severity: Minor
Found in class/HMS_Roommate.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function show has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function show()
    {
        # Get the roommate request record from the database
        $bed = new Bed($this->request['bed_id']);
        $room = $bed->get_parent();
Severity: Minor
Found in class/LotteryRoommateRequestView.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function show has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function show()
    {
        if(!UserStatus::isAdmin() || !\Current_User::allow('hms', 'edit_terms')) {
            throw new PermissionException('You do not have permission to edit terms.');
        }
Severity: Minor
Found in class/TermEditView.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ($this->_curr_assignment == NULL && \Current_User::allow('hms', 'bed_structure') && UserStatus::isAdmin()) {
            $deleteBedCmd = CommandFactory::getCommand('DeleteBed');
            $deleteBedCmd->setBedId($this->id);
            $deleteBedCmd->setRoomId($this->room_id);
Severity: Major
Found in class/Bed.php and 1 other location - About 1 hr to fix
class/Room.php on lines 576..586

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (\Current_User::allow('hms','room_structure') && $this->get_number_of_assignees() == 0) {
            $deleteRoomCmd = CommandFactory::getCommand('DeleteRoom');
            $deleteRoomCmd->setRoomId($this->id);
            $deleteRoomCmd->setFloorId($this->floor_id);
Severity: Major
Found in class/Room.php and 1 other location - About 1 hr to fix
class/Bed.php on lines 316..326

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function scanRegExpFlags has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function scanRegExpFlags() {
        var ch, str, flags, restore;

        str = '';
        flags = '';
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 1 hr to fix

Function sortOptions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

$.fn.sortOptions = function(ascending)
{
    // get selected values first
    var sel = $(this).selectedValues();
    var a = typeof(ascending) == "undefined" ? true : !!ascending;
Severity: Minor
Found in javascript/jquery.selectboxes.js - About 1 hr to fix

Function reinterpretAsAssignmentBindingPattern has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function reinterpretAsAssignmentBindingPattern(expr) {
        var i, len, property, element;

        if (expr.type === Syntax.ObjectExpression) {
            expr.type = Syntax.ObjectPattern;
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 1 hr to fix

Method show has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function show()
    {
        $this->setTitle($this->reportCtrl->getFriendlyName() . ' Detail');
        $tpl = array();
Severity: Minor
Found in class/ReportDetailView.php - About 1 hr to fix

Function 35 has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

},{}],35:[function(_dereq_,module,exports){
/**
 * Copyright 2014 Facebook, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 1 hr to fix

Method execute has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context)
    {
        // Check permissions
        if (!\Current_User::allow('hms', 'checkin')) {
            throw new PermissionException('You do not have permission to checkin students.');
Severity: Minor
Found in class/Command/CheckinFormSubmitCommand.php - About 1 hr to fix

Function fetchMessageDetails has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    fetchMessageDetails(messageId){
        let that = this;
        var messages = null;

        messages = that.state.messages;
Severity: Minor
Found in javascript/emailLogView/emailLogView.jsx - About 1 hr to fix

Function scanRegExpBody has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function scanRegExpBody() {
        var ch, str, classMarker, terminated, body;

        ch = source[index];
        assert(ch === '/', 'Regular expression literal must start with a slash');
Severity: Minor
Found in javascript/react/build/JSXTransformer.js - About 1 hr to fix

Method execute has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context)
    {
        if(!UserStatus::isUser()) {
            throw new PermissionException('You do not have permission to request a roommate.');
        }
Severity: Minor
Found in class/Command/RequestRoommateCommand.php - About 1 hr to fix

Function sortMembers has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    sortMembers(){
        var members = this.state.rlcMembers;
        switch(this.state.sortedBy){
            case "gender":
                members.sort(function(a,b){
Severity: Minor
Found in javascript/rlcMembersList/rlcMembersList.jsx - About 1 hr to fix

Method execute has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(CommandContext $context) {
        if(!UserStatus::isAdmin() || !\Current_User::allow('hms', 'banner_queue')){
            throw new PermissionException('You do not have permission to enable/disable the Banner queue.');
        }
Severity: Minor
Found in class/Command/ProcessBannerQueueCommand.php - About 1 hr to fix

Method showFilters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function showFilters($selection = NULL)
    {
        \PHPWS_Core::initCoreClass('Form.php');

        $submitCmd = CommandFactory::getCommand('ShowActivityLog');
Severity: Minor
Found in class/ActivityLogView.php - About 1 hr to fix

Method show has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function show()
    {
        $this->setTitle('RLC Re-application Form');

        $form = new \PHPWS_Form();
Severity: Minor
Found in class/RlcReapplicationView.php - About 1 hr to fix

Method getRoomChangesByFloor has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getRoomChangesByFloor($term, Array $floorList, Array $stateList)
    {
        $db = PdoFactory::getPdoInstance();

        $floorPlaceholders = array();
Severity: Minor
Found in class/RoomChangeRequestFactory.php - About 1 hr to fix
Severity
Category
Status
Source
Language