Showing 720 of 720 total issues
Function selectSingleValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public static function selectSingleValue($query, $types = "", $params = []) {
if (!Tools::isInstanceOf($query, new DBPreparedQuery())) {
$dbQuery = new DBPreparedQuery($query, $types, $params);
} else {
$dbQuery = $query;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
case (self::PROVIDER_FREEGEOIP_IO):
if (@strlen(trim($geoData->country_code)) == 2) {
switch ($type) {
case (self::TYPE_FULL_OBJECT):
return $geoData;- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 91.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
case (self::PROVIDER_IPINFO_IO):
if (@strlen(trim($geoData->country)) == 2) {
switch ($type) {
case (self::TYPE_FULL_OBJECT):
return $geoData;- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 91.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid too many return statements within this method. Open
return "FALSE";Avoid too many return statements within this method. Open
return @json_decode($response, true);Avoid too many return statements within this method. Open
return $geoData;Avoid too many return statements within this method. Open
return 'E_USER_ERROR';Avoid too many return statements within this method. Open
return "s";Avoid too many return statements within this method. Open
return "TRUE";Avoid too many return statements within this method. Open
return null;Avoid too many return statements within this method. Open
return 'E_STRICT';Avoid too many return statements within this method. Open
return @$geoData->geoplugin_city;Avoid too many return statements within this method. Open
return [
'country' => @$geoData->geoplugin_countryName,
'country_code' => @$geoData->geoplugin_countryCode
];Avoid too many return statements within this method. Open
return false;The method httpRedirect has a boolean flag argument $serialize, which is a certain sign of a Single Responsibility Principle violation. Open
public static function httpRedirect($url = "", $postData = [], $serialize = true) {- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Remove error control operator '@' on line 124. Open
public static function getRedirectUrl($url) {
$urlParts = @parse_url($url);
if (!$urlParts) {
return false;
}- Read upRead up
- Exclude checks
ErrorControlOperator
Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.
Example
function foo($filePath) {
$file = @fopen($filPath); // hides exceptions
$key = @$array[$notExistingKey]; // assigns null to $key
}Source http://phpmd.org/rules/cleancode.html#errorcontroloperator
Avoid too many return statements within this method. Open
return 'E_COMPILE_ERROR';Avoid too many return statements within this method. Open
return 'E_USER_WARNING';The method redirect has a boolean flag argument $serialize, which is a certain sign of a Single Responsibility Principle violation. Open
public static function redirect($url = "", $postData = [], $serialize = true) {- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid too many return statements within this method. Open
return $this->selectDBObjects();