Asymptix/Framework

View on GitHub

Showing 720 of 720 total issues

Avoid too many return statements within this method.
Open

            return "0.0";
Severity: Major
Found in framework/db/DBCore.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                                return @$geoData->geoplugin_regionName;
    Severity: Major
    Found in framework/tools/geo/LocationDetector.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                                  return $geoData;
      Severity: Major
      Found in framework/tools/geo/LocationDetector.php - About 30 mins to fix

        The method start has a boolean flag argument $useCookie, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public static function start($name = "", array $iniSettings = [], $useCookie = false,
        Severity: Minor
        Found in framework/web/Session.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
            public function bar($flag = true) {
            }
        }

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        Avoid too many return statements within this method.
        Open

                return $value;
        Severity: Major
        Found in framework/db/DBCore.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return null;
          Severity: Major
          Found in framework/tools/geo/LocationDetector.php - About 30 mins to fix

            Missing class import via use statement (line '57', column '23').
            Open

                        throw new \Exception("Invalid email: '" . $user->email . "'");
            Severity: Minor
            Found in classes/Email.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Avoid too many return statements within this method.
            Open

                            return 'E_CORE_ERROR';
            Severity: Major
            Found in classes/db/tools/ErrorLog.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return 'E_RECOVERABLE_ERROR';
              Severity: Major
              Found in classes/db/tools/ErrorLog.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return "";
                Severity: Major
                Found in classes/db/tools/ErrorLog.php - About 30 mins to fix

                  Missing class import via use statement (line '61', column '27').
                  Open

                                  throw new \Exception("Invalid view template");
                  Severity: Minor
                  Found in framework/app/View.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Avoid too many return statements within this method.
                  Open

                                  return $this->setFieldValue($fieldName, $fieldValue);
                  Severity: Major
                  Found in framework/db/DBSelector.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return 'E_CORE_WARNING';
                    Severity: Major
                    Found in classes/db/tools/ErrorLog.php - About 30 mins to fix

                      The method http_redirect has a boolean flag argument $session, which is a certain sign of a Single Responsibility Principle violation.
                      Open

                          function http_redirect($url, $params = array(), $session = false) {
                      Severity: Minor
                      Found in modules/http.php by phpmd

                      BooleanArgumentFlag

                      Since: 1.4.0

                      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                      Example

                      class Foo {
                          public function bar($flag = true) {
                          }
                      }

                      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                      Avoid too many return statements within this method.
                      Open

                                                  return @json_decode($response, true);
                      Severity: Major
                      Found in framework/tools/geo/LocationDetector.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return 'E_USER_NOTICE';
                        Severity: Major
                        Found in classes/db/tools/ErrorLog.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return 'E_DEPRECATED';
                          Severity: Major
                          Found in classes/db/tools/ErrorLog.php - About 30 mins to fix

                            The method http_redirect has a boolean flag argument $session, which is a certain sign of a Single Responsibility Principle violation.
                            Open

                                public static function http_redirect($url, $params = [], $session = false) {
                            Severity: Minor
                            Found in framework/web/Http.php by phpmd

                            BooleanArgumentFlag

                            Since: 1.4.0

                            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                            Example

                            class Foo {
                                public function bar($flag = true) {
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                            The method getAvatarPath has a boolean flag argument $icon, which is a certain sign of a Single Responsibility Principle violation.
                            Open

                                public function getAvatarPath($icon = false) {
                            Severity: Minor
                            Found in classes/db/access/User.php by phpmd

                            BooleanArgumentFlag

                            Since: 1.4.0

                            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                            Example

                            class Foo {
                                public function bar($flag = true) {
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                            Avoid too many return statements within this method.
                            Open

                                            return null;
                            Severity: Major
                            Found in framework/tools/geo/LocationDetector.php - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language